[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    PATCH: fix #39795 (Re: KDE deletes user set Xresources?)
From:       Takumi ASAKI <asataku () osk3 ! 3web ! ne ! jp>
Date:       2002-03-30 12:32:23
[Download RAW message or body]

Takumi ASAKI wrote:

>Hi.
>
>after 3.0RC3, KDE deletes my X-resource when startup.
># I report it as bug #39795
># http://bugs.kde.org/db/39/39795.html
>
>So I check source.
>I found krdb delete all X-resource when startup.
>And I read http://lists.kde.org/?l=kde-core-devel&m=101634013107727&w=2
>It occurs when checkbox off "Apply colors to non-KDE apps".
>
>But KDE deletes X-resource when checkbox on "Apply colors to non-KDE apps".
>Because krdb call xrdb without option.
>so xrdb delete old resources and load new(kde-setting) resources.
>
>So, KDE always delete X-resources when startup.
>Is it KDE's style?
>User shouldn't set X-resources before startkde?
>So when user should set resources?
>
>Current behavior is NOT USEFUL.
>
>Please DON'T DELETE user set resources.

I wrote a patch to fix it.
This patch change krdb to don't delete X-resoruce.

1. checkbox on "Apply colors to non-KDE apps".
    execute xrdb with -merge option
2. checkbox off "Apply colors to non-KDE apps".
    Don't delete any X-resource.

Please reveiw it.

-- 
  Che Che - Bye Bye
        From: Takumi ASAKI <asataku@osk3.3web.ne.jp>
	URL: http://www3.osk.3web.ne.jp/~asataku/

["kdebase-3.0-cvs-krdb-xresources-20020328.diff" (text/x-diff)]

--- kdebase/kcontrol/krdb/krdb.cpp.orig	Thu Mar 28 08:37:04 2002
+++ kdebase/kcontrol/krdb/krdb.cpp	Thu Mar 28 23:32:43 2002
@@ -416,7 +416,7 @@
     tmpFile.close();
 
     KProcess proc;
-    proc << "xrdb" << tmpFile.name();
+    proc << "xrdb" << "-merge" << tmpFile.name();
     proc.start( KProcess::Block, KProcess::Stdin );
 
     tmpFile.unlink();
@@ -427,6 +427,7 @@
     kdDebug() << "krdb: XDeleteProperty()" << endl;
     applyGtkStyles(false);
 
+#if 0
     // Undo the property xrdb has placed on the root window (if any).
     Atom resource_manager;
     resource_manager = XInternAtom( qt_xdisplay(), "RESOURCE_MANAGER", True);
@@ -439,6 +440,7 @@
     qt_desktop_properties = XInternAtom( qt_xdisplay(), "_QT_DESKTOP_PROPERTIES", True);
     if (qt_desktop_properties != None)
       XDeleteProperty( qt_xdisplay(), qt_xrootwin(), resouce_manager);	*/
+#endif
   }
 
   /* Qt exports */

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]