[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: New Application Announcement - KLego
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <ingo.kloecker () epost ! de>
Date:       2002-03-08 0:52:34
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 07 March 2002 23:32, Andy Goossens wrote:
> On Thursday 7 March 2002 23:10, Rolf Magnus wrote:
> > On Thursday 07 March 2002 22:53, Andy Goossens wrote:
> > > It easier when you put http:// in front of an url, so anyone who
> > > uses KMail can click on the link. Yeah yeah, I'm lazy too :-)
> >
> > Btw: kmail shouldn't treat http:// without a following server name
> > as a link ;)

I doesn't for me. Guess why.

> I can see you're running the CVS version:
> "X-Mailer: KMail [version 1.3.99]"

Look at the header of this message. ;-)

> Delay the release, we have a showstopper bug! :-)

Oh my God!

> Clicking the link does no harm. It seems smart enough to ignore the
> click on an invalid link. Anyone from the KMail developers reading
> this?

Yes. Why? ;-)

Regards,
Ingo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8iAtdGnR+RTDgudgRAgaQAJoCWkohvt0hcKqCfAP2WqN/GzANMQCeOSAR
rAAf5Q9Ke5Fl7yNEbexew3Q=
=iZzy
-----END PGP SIGNATURE-----

["dont_link_to_empty_urls.diff" (text/x-diff)]

--- kmreaderwin.cpp~	Mon Mar  4 20:50:29 2002
+++ kmreaderwin.cpp	Fri Mar  8 01:49:08 2002
@@ -1590,7 +1590,12 @@ QString KMReaderWin::strToHtml(const QSt
 	pos--;
       }
       str.truncate(i);
-      result += "<a href=\"" + str + "\">" + str + "</a>";
+      // don't create link if url is empty
+      if( ( str == "http://" ) || ( str == "https://" ) ||
+          ( str == "ftp://" ) || ( str == "mailto" ) )
+        result += str;
+      else
+        result += "<a href=\"" + str + "\">" + str + "</a>";
     }
     else if (ch=='@')
     {

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]