[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    PATCH - KBackgammon, please review
From:       Jens Hoefkens <jens () hoefkens ! com>
Date:       2002-02-27 19:34:59
[Download RAW message or body]

Hi Folks.

After being without normal computer access for three month (and missing most 
of the KDE3 development because of that), I am now back and working again on 
KBackgammon.

Attached is a patch that updates/fixes some problems with the program:

1) Version number update
2) Fix QRegExp bugs in KBgFIBS
3) Use the 'real' scrollToBottom() for KBgTextView
4) Use KListViewItem instead of QListViewItem in KPlayerList
5) Update a comment in KBgFIBSChat

Unless I hear any objections, I will check the changes into CVS tomorrow.

-- 

Cheers,
Jens
["kbackgammon.patch" (text/x-diff)]

Index: kbgtextview.cpp
===================================================================
RCS file: /home/kde/kdegames/kbackgammon/kbgtextview.cpp,v
retrieving revision 1.6
diff -r1.6 kbgtextview.cpp
61,62c61
< 	scrollBy(0,99999);
< 	viewport()->repaint();
---
> 	scrollToBottom();
81d79
< 	//clear();
Index: version.h
===================================================================
RCS file: /home/kde/kdegames/kbackgammon/version.h,v
retrieving revision 1.6
diff -r1.6 version.h
28,29c28,29
< #define PROG_VERSION   "2.2.0"
< #define PROG_HOME      "http://backgammon.sourceforge.net/"
---
> #define PROG_VERSION   "2.5.0"
> #define PROG_HOME      "http://www.hoefkens.com/lnx/kbg.html"
Index: engines/fibs/kbgfibs.cpp
===================================================================
RCS file: /home/kde/kdegames/kbackgammon/engines/fibs/kbgfibs.cpp,v
retrieving revision 1.11
diff -r1.11 kbgfibs.cpp
1223,1224c1223,1224
< 	pat[BoxVer1] = QRegExp("^ *|");
< 	pat[BoxVer2] = QRegExp("| *$");
---
> 	pat[BoxVer1] = QRegExp("^ *\\|");
> 	pat[BoxVer2] = QRegExp("\\| *$");
1345c1345
< 	rxCollect += "<br><pre>     </pre>" + line;
---
> 	rxCollect += "<br>&nbsp;&nbsp;&nbsp;&nbsp;" + line;
Index: engines/fibs/kbgfibschat.cpp
===================================================================
RCS file: /home/kde/kdegames/kbackgammon/engines/fibs/kbgfibschat.cpp,v
retrieving revision 1.16
diff -r1.16 kbgfibschat.cpp
668,670d667
<  *
<  * FIXME: RMB on an item that is _below_ the first visible part (i.e. after
<  * scrollbars have been added, don't work. This seems to be a Qt problem...
Index: engines/fibs/kplayerlist.cpp
===================================================================
RCS file: /home/kde/kdegames/kbackgammon/engines/fibs/kplayerlist.cpp,v
retrieving revision 1.12
diff -r1.12 kplayerlist.cpp
75c75
< class KFibsPlayerListLVI : public QListViewItem {
---
> class KFibsPlayerListLVI : public KListViewItem {
82c82
<     KFibsPlayerListLVI(KFibsPlayerList *parent) : QListViewItem(parent) { _plist = parent; }
---
>     KFibsPlayerListLVI(KFibsPlayerList *parent) : KListViewItem(parent) { _plist = parent; }

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]