[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: [REPOST - again - please read!] KonqPropsView - BIC?
From: Simon MacMullen <simon.macmullen () aspect-proteus ! com>
Date: 2002-02-19 17:34:20
[Download RAW message or body]
What's wrong? Do I smell? I know I'm using Outlook but I can stop :)
Please look at this patch - I want to be able to add my folder mimetype
feature to konqueror in 3.1.
The original post is at:
http://lists.kde.org/?l=kde-devel&m=101377257913942&w=2
-----Original Message-----
From: Simon MacMullen
Sent: 15 February 2002 16:18
To: 'kde-devel@kde.org'
Subject: RE: KonqPropsView - BIC?
David Faure said:
> Don't worry at this point, break BC, please add a d pointer
> while you're at it. Thanks.
Attached.
> Hmmm... please be aware that KonqPropsView is the class that allows
> settings to be either global or specific to a directory, when
> Settings /
> Save View Properties in directory is enabled. If you plan to make that
> option a menu item in the View menu, then it's the right choice.
> But if you plan to make it a global config option in "Configure
> Konqueror", better make that a simple bool from reading the
> config file and NOT using KonqPropsView.
Hmmm. As far as I'm concerned, this feature is analogous to "Show Hidden
Files" or "Preview > Text files". I was planning on putting it into the View
menu.
And then (maybe) moving some of these icon view things into a (non-modal?)
dialog. Or maybe even a sidebar thing. Or something. Along with the
"Increase size of previews" option like Malte suggested. And maybe "Show
previews at size greater than 16/32/48/64".
I hadn't thought of the per-directory options though. I was only very
vaguely aware of their existence... But if you can configure (eg) previews
on a per-directory basis, you should be able to configure folder mime types
similarly. Incidentally, can anyone think of a better name for the option?
But this notional folder options dialog might get confusing if some of the
options are per-directory and some are not. What do you think?
Cheers,
Simon
["libkonq.diff" (application/octet-stream)]
Index: konq_propsview.cc
===================================================================
RCS file: /home/kde/kdebase/libkonq/konq_propsview.cc,v
retrieving revision 1.66
diff -u -3 -p -r1.66 konq_propsview.cc
--- konq_propsview.cc 2001/10/12 10:15:14 1.66
+++ konq_propsview.cc 2002/02/15 15:55:35
@@ -60,6 +60,11 @@ static QPixmap wallpaperPixmap( const QS
return QPixmap();
}
+struct KonqPropsView::Private
+{
+ // Move along, nothing to see...
+};
+
KonqPropsView::KonqPropsView( KInstance * instance, KonqPropsView * defaultProps )
: m_bSaveViewPropertiesLocally( false ), // will be overriden by setSave... anyway
// if this is the default properties instance, then keep config object for saving
Index: konq_propsview.h
===================================================================
RCS file: /home/kde/kdebase/libkonq/konq_propsview.h,v
retrieving revision 1.42
diff -u -3 -p -r1.42 konq_propsview.h
--- konq_propsview.h 2001/02/19 00:57:32 1.42
+++ konq_propsview.h 2002/02/15 15:55:35
@@ -124,6 +127,7 @@ private:
int m_iIconSize;
int m_iItemTextPos;
bool m_bShowDot;
+ bool m_bShowFolderMimeTypes; // Feature to be implemented in 3.1
QStringList m_preview;
QColor m_textColor;
QColor m_bgColor;
@@ -148,6 +152,14 @@ private:
// then m_defaultProps points to the "default properties" instance
// Otherwise it's 0L.
KonqPropsView * m_defaultProps;
+
+ /**
+ * Private data for KonqPropsView
+ * Implementation in konq_propsview.cc
+ */
+ struct Private;
+
+ Private *d;
private:
KonqPropsView( const KonqPropsView & );
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic