[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: kdelibs-3.0beta2 on IRIX
From:       Jesse Barnes <jbarnes () sgi ! com>
Date:       2002-02-14 19:01:16
[Download RAW message or body]

On Thu, Feb 14, 2002 at 01:07:09PM +0100, David Faure wrote:
> > o arts/flow/gsl/gslengine.h:91,97, const qualifiers shouldn't be
> >   there?  connected is modified in glsopmaster.c
> > o arts/flow/gsl/gsltests.c:534, arguments out of order
> > o arts/flow/gsl/gslglib.h should use HAVE_ALLOCA_H instead of
> >   GLIB_HAVE_ALLOCA_H or otherwise define it
> > o arts/flow/gsl/gslopnode.h doesn't define OP_DEBUG for non-gcc/DEC cc
> >   compilers
> 
> Please mail arts patches to stefan@space.twc.de if he doesn't notice
> them here.

Ok, will do.

> > o khtml/khtml_run.cpp, same namespace bug as above
> As below, I suppose ? ;)
> Or ?
> I saw nothing about khtml_run.cpp in the attached patches.....

Hmm... must have missed that one in the patch.

> Would it work if you add "using namespace Blah" in the .cpp
> file, right before the #include "blah.moc" line - making that one
> the last line of the file if not already last ? This sounds much
> safer to me.
> I've seen this already in other places :
> [....]
> using namespace KParts;
> #include "blah.moc"
> EOF

Yeah, this looks a bit better.  Should I submit another patch or would
you like to make these changes?

Thanks,
Jesse
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]