[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    RE: [PATCH] Random wallpapers
From:       Simon MacMullen <simon.macmullen () aspect-proteus ! com>
Date:       2002-02-12 11:27:54
[Download RAW message or body]

From: David Faure [mailto:david@mandrakesoft.com]
> Hmm, hold on.
> It didn't compile, since NoMultiRandom wasn't defined. I 
> thought it was an existing
> mode, but it seems it's a mode you added. Adding to 
> bgsettings.h (wasn't in the patch)

Arrrgh. Sorry.

> makes it compile. But..... indeed this isn't really an 
> elegant solution at all :(
> If someone adds another option, we'll have 2^3=8 combinations 
> to handle now ? ;}
> It looks like the right fix is to separate the "randomness" 
> setting from the "single/multi"
> setting.

You are of course quite right. However, this fix involves relatively few
lines of code, and 3.0 is quite close. Obviously seperating it out into two
settings is the way to go, but I don't understand the way bgsettings sticks
all its settings in and out of hash tables so I was reluctant to add another
setting and possibly introduce a worse bug. I will have a go though if you
definitely won't take this patch.

Anyway, no-one's added another option since 2.0. ;)

Simon
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]