[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: large line spaceing (again)
From:       Ewald Snel <ewald () rambo ! its ! tudelft ! nl>
Date:       2002-01-16 18:50:17
[Download RAW message or body]

Hi,

> Hi!
> just wonder if the line spaceing problem will still be in the next beta/rc1
> release of KDE3
>
> switching  a lot between KDE 2.2.x and KDE3 I "feel" realy uncomfortable
> with the large line spacing of KDE3-HEAD. IMHO it greatly reduces
> productivity because the "compact" look and feel of pre KDE3/QT3 versions
> is lost. In all menus and documents less lines are displayed thus
> increasing the need to scroll.

Yes, this is a bug in Qt-3.x. However, just fixing Qt-3.x is no longer 
possible, as KDE-3.x seems to work around this problem by adjusting some 
code. This means that without the patch almost everything looks a bit ugly, 
but with the patch some things (like dialog buttons) will be too small. 
There's no easy fix now. :((

If you want to try it, I have included an old patch for Qt-3.x (see below). 
As you can see, Qt-3.x uses the "max_bounds.ascent" instead of "ascent" for 
normal X11 fonts, which means that a single character (tallest) will 
determine the height of a font.

bye,

ewald

--- qt-x11-free-3.0.0-cvs20011007/src/kernel/qfont_x11.cpp.cute Sun Oct  7 
17:51:56 2001
+++ qt-x11-free-3.0.0-cvs20011007/src/kernel/qfont_x11.cpp      Sun Oct  7 
17:52:07 2001
@@ -2874,7 +2874,7 @@
 #endif // QT_NO_XFTFREETYPE

     XFontStruct *f = (XFontStruct *) qfs->handle;
-    return (int) (f->max_bounds.ascent * qfs->scale);
+    return (int) ((f->ascent + (f->ascent >> 3)) * qfs->scale);
 }


@@ -2902,7 +2902,7 @@
 #endif // QT_NO_XFTFREETYPE

     XFontStruct *f = (XFontStruct *) qfs->handle;
-    return (int) ((f->max_bounds.descent - 1)*qfs->scale);
+    return (int) ((f->descent - 1)*qfs->scale);
 }


@@ -3083,7 +3083,7 @@
 #endif // QT_NO_XFTFREETYPE

     XFontStruct *f = (XFontStruct *) qfs->handle;
-    return (int) ((f->max_bounds.ascent + f->max_bounds.descent) * 
qfs->scale);
+    return (int) ((f->ascent + (f->ascent >> 3) + f->descent) * qfs->scale);
 }


@@ -3111,8 +3111,7 @@
        l = xftfs->height - (xftfs->ascent + xftfs->descent);
     else
 #endif // QT_NO_XFTFREETYPE
-       l = (int) ((f->ascent + f->descent - f->max_bounds.ascent -
-                   f->max_bounds.descent) * qfs->scale);
+       l = 0;

     return (l > 0) ? l : 0;
 }
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]