From kde-devel Fri Nov 30 19:09:36 2001 From: David Faure Date: Fri, 30 Nov 2001 19:09:36 +0000 To: kde-devel Subject: Re: Compiling with -Wall X-MARC-Message: https://marc.info/?l=kde-devel&m=100714754302297 On Friday 30 November 2001 22:06, Marc Mutz wrote: > On Friday 30 November 2001 19:32, David Faure wrote: > > > > Hell knows why there are so many functions taking QStrings and > > > immediately doing .latin1() on them... :-( > > > > Because e.g. libkonqueror.la will always be a latin1 string. It's not > > like we're going to name a library ικΩ anytime soon. > > > Yes, and charset names will never, ever be anything other than us-ascii, > just as language tags and probably icon names and help anchors and - > you name it. > It's only: Why do those functions take a _QString_ as argument in the > first place? I mean - is const char * considered so bad that it's not > allowed as arg type? Yes, char * poses the problem of ownership - who deletes it, etc. But on other hand, I agree that this code could make use of QCString where appropriate... -- David FAURE, david@mandrakesoft.com, faure@kde.org http://perso.mandrakesoft.com/~david/ , http://www.konqueror.org/ KDE 3.0: Konquering the Desktops >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<