[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: kdelibs/kdecore
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-11-28 17:46:44
[Download RAW message or body]

On Wednesday 28 November 2001 16:59, Ryan Cumming wrote:
> On November 28, 2001 04:34, you wrote:
> > On Wednesday, 28. November 2001 02:45, Ryan Cumming wrote:
> > > > Fixed findExe so that it accepts symlinks to executables, okayed by
> > > > coolo. if( info.exists() && ( ignore || info.isExecutable() )
> > > > -           && info.isFile() ) {
> > > > +           && ( info.isFile() || info.isSymLink() )  ) {
> > >
> > > Ack! What if it's a symlink to a device? Do bad, evil things happen?
> > > Maybe you should deference the symlink and then check for the executable
> > > flag. I know it sounds like a corner case, but most /dev's are full of
> > > symlinks to 'executable' (ioctl()able) device nodes, and it isn't too
> > > unreasonable to see device symlinks even outside of the /dev tree.
> >
> > What's so special about executable files in /dev? You can make even gifs
> > executable and it give it the name ls. What's happening is, that the the
> > execing call will fail.
> 
> Er, anyways, what I'm saying is that the original test said "if this is a 
> normal file and executable", and the new test says "if this is a normal file, 
> or a symlink to -anything-, and it's executable", and the new test is 
> obviously not in the spirit of the old test.

Maybe that's why I changed it ? ;-)

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/ , http://www.konqueror.org/
KDE 3.0: Konquering the Desktops

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]