[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Redirection problem + How to get files in Sidebar?
From:       Michael Goffioul <goffioul () imec ! be>
Date:       2001-11-12 17:43:59
[Download RAW message or body]

> Wow, you digged up all the nasty tricks available in kio ;-)

You have to, sometimes...

> Looks good to me - although it would helpful to add a comment about the
> fact that this effectively tests for the guessed_mimetype thing.
> Usually isMimeTypeKnown is used in a case where the mimetype-determination
> is delayed, which isn't the case in the dirtree. You're simply using the
> code from isMimeTypeKnown to detect that the mimetype was guessed.
> 
> In fact......... a isMimeTypeGuessed() in KFileItem would be better IMHO,
> to avoid mixing the two things. Can you add that instead and use that
> in the dirtree ? It looks very strange if the dirtree calls isMimeTypeKnown
> which is about delayed mimetype-determination :P

For me it doesn't matter. Actually, I'm using the guessed mime type only to
force konqueror to "stat()" the file/dir. I used isMimeTypeKnown() because
the code change was minimum. I can do it as you suggested: I'll do it
tomorrow and post a patch for review before commiting.

Bye.
Michael.

-- 
------------------------------------------------------------------
Michael Goffioul		IMEC-DESICS-MIRA
e-mail: goffioul@imec.be	(Mixed-Signal and RF Applications)
Tel:    +32/16/28-8510		Kapeldreef, 75
Fax:    +32/16/28-1515		3001 HEVERLEE, BELGIUM
------------------------------------------------------------------
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]