[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Semantics of colours in kicker taskbar buttons
From:       Adriaan de Groot <adridg () cs ! kun ! nl>
Date:       2001-10-24 10:39:23
[Download RAW message or body]

Well, Clee finally convinced me to try his dotNet style, and then I
started messing around with some color settings, etc. Normally I'm not an
eyecandy kinda guy, but the following inconsistency bothers me:

The following KDE 2.2 styles use KGlobalSettings::highlighted() to draw
the background of the currently active window in the kicker taskbar:
dotNet and webStyle. The rest -- well, all those I tested -- use
KGlobalSettings::background() instead. In response, kicker draws the
window title using KGlobalSettings::text() as a color, which looks
dreadful on KGlobalSettings::highlighted(), where you need to use
KGlobalSettings::highlightedText() instead.

Which *should* it be? Or do we leave that to styles developers and hope
that users pick sensible combinations of colors and styles (I happen to
like black text, with dark blue text selection and white text, so dotNet
gives me black text on dark blue for the active kicker taskbar button)?

Patches either way are minimal, and I *don't* think adding some kind of
flag to a style to tell kicker to draw things one particular way or the
other is the "right thing to do" (although, another convention could be
that drawKickerTaskButton must leave the painter with the pen color set to
a suitable color for the text, and remove the setPen() calls from
TaskContainer::drawButton alltogether).

Comments either way, preferably yielding a shorter thread than the
doubleclick-on-toolbars one?

-- 
+------------------------------+--------------------------------------------+
+ Adriaan de Groot             + Project: FRESCoS                           +
+ adridg@cs.kun.nl             + Private: adridg@sci.kun.nl                 +
+ Kamer A6020 tel. 024 3652272 + http://www.cs.kun.nl/~adridg/frescos/      +

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]