[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: PATCH: Fix KMixApplet for vertical panels
From:       Waldo Bastian <bastian () kde ! org>
Date:       2001-10-23 23:48:59
[Download RAW message or body]

On Tuesday 23 October 2001 12:51 pm, Erik Sigra wrote:
> This patch fixes the KMixApplet for vertical panels. The bug in question is
> now 322 days old so I thought it was time to do something about it. (The
> bug page is "http://bugs.kde.org/db/16/16203.html".)

The patch causes a segfault in "heightForWidth()" here due to neither 
m_mixerWidget nor m_errorLabel being non-null. Could it be that the patch 
shouldn't remove the if (mixer) { m_mixerWidget = ... } block ?

Apart from that could you please use "!" and "||" instead of "not" and "or" 
in if-expressions? 

Cheers,
Waldo
-- 
bastian@kde.org | SuSE Labs KDE Developer | bastian@suse.com
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]