[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/kicker/buttons
From:       Antonio Larrosa Jimenez <larrosa () kde ! org>
Date:       2003-03-15 2:37:35
[Download RAW message or body]

CVS commit by antlarr: 

Reverting part of 1.33 to fix the problem some people have with kicker
painting garbage on the background of buttons
 ( http://developer.kde.org/~larrosa/tmp/kicker-garbage.jpg )
It seems to work correctly with a transparent kicker too, so I suppose it's
ok to revert.

CCMAIL: zack@kde.org


  M +2 -16     panelbuttonbase.cpp   1.34


--- kdebase/kicker/buttons/panelbuttonbase.cpp  #1.33:1.34
@@ -423,20 +423,6 @@ void PanelButtonBase::drawButton(QPainte
     if (!_bg.isNull())
         p->drawPixmap(0, 0, _bg);
-    else {
-        QPixmap *pm =  colorGroup().brush( QColorGroup::Background).pixmap();
-        if ( pm ) {
-            QPixmap mbg( width(), height() );
-
-            QWidget *wid = static_cast<QWidget*>(Panel::the()->containerArea());
-            if ( !wid )
-                kdWarning()<<k_funcinfo<<" there was a serious kicker transparency error!"<<endl;
-            QPoint tl = mapTo(wid, rect().topLeft());
-            QPoint lr = mapTo(wid, rect().bottomRight());
-            bitBlt(&mbg, QPoint(0,0), pm, QRect(tl, lr), CopyROP);
-
-            p->drawPixmap( 0, 0, mbg);
-        } else
+    else 
             p->fillRect(rect(), colorGroup().brush(QColorGroup::Background));
-    }
 
     const QPixmap& tile = (isDown() || isOn()) ? _down : _up;


[prev in list] [next in list] [prev in thread] [next in thread]