[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kio/kio
From:       Dirk Mueller <mueller () kde ! org>
Date:       2003-02-11 16:05:07
[Download RAW message or body]

On Die, 11 Feb 2003, David Faure wrote:

> I don't see what was wrong with the previous code :(

The previous code made a deep copy of a KService object, which doesn't work 
as KService contains pointers and has no explicit copy constructor that 
fixes them. Therefore, you ended up having double deletions in some places 
and for some reason this liked to crash dcopserver and other things, at 
least your KDE session died when you entered a command in ALT-F2, 
or ran "View Source" in Konqueror hung all konqueror instances, which was 
pretty annoying for me ;-)

Maybe KService should have a copy constructor or should have a private copy 
constructor declaration to avoid this problem. I've added the latter and 
started a full build to see which other app breaks, but this build is still 
running and I still have to fix all the other build breakages in HEAD 
first to see what else might be broken by it. 

Feel free to fix it in a different way. 


-- 
Dirk (received 412 mails today)
[prev in list] [next in list] [prev in thread] [next in thread]