[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kdoctools
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2002-12-07 8:54:48
[Download RAW message or body]

On Sat, Dec 07, 2002 at 01:52:32AM +0100, Dirk Mueller wrote:
> CVS commit by mueller: 
> 
> it links libkdefakes so this is safer..
> 
everything (except arts and qt) links kdefakes. still, our version is
only used if no other version is present at all.

anyway, i repeat that we should not workaround snprintf breakages of
any systems nobody uses (and kde probably does not even built on).
snprintf is standardized by ISO/IEC 9899:1999. anything behaving
differently is simply broken and i see no reason to make our code less
readable and efficient because of it. add a configure check that simply
bails on failure and things are good (i think any affected person should
be happy to be told that his c lib is insecure and should be upgraded,
as kde is certainly not the only affected package).
 
> +    vsnprintf(&buffer[strlen(buffer)], sizeof(buffer)-strlen(buffer)-1, msg, args);
>  
... and consequently the "-1" should go away.

greetings

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.
[prev in list] [next in list] [prev in thread] [next in thread]