[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdeutils/klaptopdaemon [POSSIBLY UNSAFE]
From:       Waldo Bastian <bastian () kde ! org>
Date:       2002-12-06 15:40:10
[Download RAW message or body]

On Friday 06 December 2002 16:21, Oswald Buddenhagen wrote:
> > +	s = fscanf(f, "%255s %d.%d %x %x %x %x %d%% %d %s\n",
>
> seriously, if you can prove that it's poinless to add additional safety,
> then don't bother to make the code less readable. maybe add a comment.

The problem is that code tends to be copied&pasted, so to promote best 
practice it is essential that all code in KDE CVS does indeed follow best 
practice. That way we have hopefully less to do when we import a new 
application in KDE CVS.

Cheers,
Waldo
-- 
bastian@kde.org -=|[ SuSE, The Linux Desktop Experts ]|=- bastian@suse.com

[prev in list] [next in list] [prev in thread] [next in thread]