[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: knotify,ksmserver and kdeinit
From:       Lubos Lunak <l.lunak () sh ! cvut ! cz>
Date:       2001-09-03 18:00:26
[Download RAW message or body]

Dne ne 2. z��� 2001 23:18 Stefan Westerfeld napsal(a):
>    Hi!
>
> On Sun, Sep 02, 2001 at 09:51:07PM +0200, Lubos Lunak wrote:
> >  in the startkde script, knotify is not started using kdeinit, and the
> > comment says it's because knotify uses threads and kdeinit does not. I
> > wonder why knotify is compiled as a kdeinit module then. And it's even
> > used, in KNotifyClient::startDaemon() ( kdelibs/kdecore ), which uses
> > startServiceByDesktopName(), which in turn uses kdeinit ( i.e. knotify is
> > kdeinit started e.g. if one runs standalone KWin without full KDE ).
> > Moreover, it seems to work fine here ( Linux ). Is it broken only on some
> > platforms ?
>
> It used to work only on some platforms. However, with the complete
> libmcop_mt = threads/libmcop = no threads seperation that I committed
> shortly before KDE2.2, it should work on all platforms. Feel free to fix
> it.

 Ok, I will, also in 2_2_BRANCH ( call it a bugfix for a 0,5MB memory bug ).
 May I also commit in 2_2_BRANCH the two attached patches for people, who 
don't use khotkeys and kxmlrpcd ( each of them should fix another cca 0,5MB 
bug, maybe even more ) ?

 Lubos Lunak
--
 l.lunak@email.cz ; l.lunak@kde.org
 http://dforce.sh.cvut.cz/~seli

["khotkeys.patch" (text/x-diff)]

diff -u3 -p -d -N -r kdebase.bak/khotkeys/kcontrol/kcmkhotkeys.cpp \
                kdebase/khotkeys/kcontrol/kcmkhotkeys.cpp
--- kdebase.bak/khotkeys/kcontrol/kcmkhotkeys.cpp	Tue Aug 14 22:12:42 2001
+++ kdebase/khotkeys/kcontrol/kcmkhotkeys.cpp	Mon Sep  3 10:14:39 2001
@@ -166,10 +166,13 @@ void write_conf( KHotData_dict& data_P )
         KSimpleConfig cfg( CONFIG_FILE, false );
         data_P.write_config( cfg );
         }
-    DCOPClient* client = kapp->dcopClient();
-    QByteArray data;
-    client->send( "khotkeys", "khotkeys", "reread_configuration()", data );
-      // tell daemon to reread cfg file
+    if( !kapp->dcopClient()->isApplicationRegistered( "khotkeys" ))
+        KApplication::kdeinitExec( "khotkeys" );
+    else
+        {
+        QByteArray data;
+        kapp->dcopClient()->send( "khotkeys*", "khotkeys", "reread_configuration()", \
data ); +        }
     }
     
 bool edit_shortcut( const QString& action_name_P, KHotData* item_P,
diff -u3 -p -d -N -r kdebase.bak/khotkeys/khotkeys/khotkeys.desktop \
                kdebase/khotkeys/khotkeys/khotkeys.desktop
--- kdebase.bak/khotkeys/khotkeys/khotkeys.desktop	Fri Aug 24 22:30:49 2001
+++ kdebase/khotkeys/khotkeys/khotkeys.desktop	Mon Sep  3 10:42:06 2001
@@ -41,3 +41,4 @@ Name[zh_CN.GB2312]=KDE 热键
 Name[zh_TW.Big5]=KDE 熱鍵
 Type=Service
 X-KDE-StartupNotify=false
+X-KDE-autostart-condition=khotkeysrc:Main:Num_Sections:false


["kxmlrpcd.patch" (text/x-diff)]

diff -u3 -p -d -N -r kdebase.bak/kxmlrpc/kxmlrpcinit.cpp kdebase/kxmlrpc/kxmlrpcinit.cpp
--- kdebase.bak/kxmlrpc/kxmlrpcinit.cpp	Wed Sep 20 08:00:41 2000
+++ kdebase/kxmlrpc/kxmlrpcinit.cpp	Mon Sep  3 10:55:49 2001
@@ -10,7 +10,7 @@ extern "C"
         KConfig *config = new KConfig( "kxmlrpcdrc", true, false );
         config->setGroup( "General" );
 
-        if ( config->readBoolEntry( "StartServer", true ) )
+        if ( config->readBoolEntry( "StartServer", false ) )
             kapp->startServiceByDesktopName( "kxmlrpcd" );
 
 	delete config;


[prev in list] [next in list] [prev in thread] [next in thread]