[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Fwd: audiocd:/ - VBR and Xing tag
From:       Ralf Nolden <nolden () kde ! org>
Date:       2001-09-02 10:13:25
[Download RAW message or body]

In case someone didn't read kde-devel fromt he audiocd writers, please take 
care of Pavel's patch and if you don't want to commit it for whatever reason, 
at least tell him why and don't ignore him :)

Thanks,

Ralf

----------  Forwarded Message  ----------

Subject: audiocd:/ - VBR and Xing tag
Date: Sun, 02 Sep 2001 09:41:55 +0200
From: Pavel Troller <patrol@arcus.sinus.cz>
To: kde-devel@kde.org

Hi!
   I've played with audiocd ioslave to enable VBR in mp3. (I already sent a
 patch about 3 months ago but it was neither commited nor rejected, it was
 simply ignored). However, I still fight with the problem that created mp3's
 don't contain the Xing tag, which really messes up xmms or other players.
   It seems that the Xing tag writting flag is reset internally in libmp3lame
 - it contains a lot of tests and one of them resets Xing when the output
 file is stdout or not specified, which is, I'm afraid, our case, because the
 ioslave works as a pipe - am I right ?
   For Your convenience, I'm attaching the patch again. It is against
 KDE_2_2_BRANCH. Could somebody, especially the audiocd's author, help me
 with this ?

                                         With regards, Pavel Troller

-------------------------------------------------------



-- 
We're not a company, we just produce better code at less costs.
--------------------------------------------------------------------
Ralf Nolden
nolden@kde.org

The K Desktop Environment	The KDevelop Project
http://www.kde.org		http://www.kdevelop.org


["Anhang: 1" (text/plain)]

? audiocd.diff
Index: audiocd.cpp
===================================================================
RCS file: /home/kde/kdebase/kioslave/audiocd/audiocd.cpp,v
retrieving revision 1.23
diff -u -3 -p -r1.23 audiocd.cpp
--- audiocd.cpp	2001/07/22 00:33:09	1.23
+++ audiocd.cpp	2001/09/02 06:49:49
@@ -1268,7 +1268,7 @@ void AudioCDProtocol::getParameters() {
       
     }
 
-    if ( config->readBoolEntry("write_xing_tag",true) ) lame_set_bWriteVbrTag(d->gf, 1);
+    lame_set_bWriteVbrTag(d->gf, config->readBoolEntry("write_xing_tag",true));
 
   }
 
Index: kcmaudiocd/kcmaudiocd.cpp
===================================================================
RCS file: /home/kde/kdebase/kioslave/audiocd/kcmaudiocd/kcmaudiocd.cpp,v
retrieving revision 1.10
diff -u -3 -p -r1.10 kcmaudiocd.cpp
--- kcmaudiocd/kcmaudiocd.cpp	2001/07/24 16:37:21	1.10
+++ kcmaudiocd/kcmaudiocd.cpp	2001/09/02 06:49:50
@@ -148,10 +148,10 @@ KAudiocdModule::KAudiocdModule(QWidget *
     //MP3 VBR Groupbox
     connect(vbr_average_br,SIGNAL(clicked()),this,SLOT(slotUpdateVBRWidgets()));
     connect(vbr_min_hard,SIGNAL(clicked()),this,SLOT(slotConfigChanged()));
-    connect(vbr_min_br,SIGNAL(clicked()),this,SLOT(slotConfigChanged()));
+    connect(vbr_min_br,SIGNAL(clicked()),this,SLOT(slotUpdateVBRCombos()));
     connect(vbr_min_brate,SIGNAL(activated(int)),SLOT(slotConfigChanged()));
 
-    connect(vbr_max_br,SIGNAL(clicked()),this,SLOT(slotConfigChanged()));
+    connect(vbr_max_br,SIGNAL(clicked()),this,SLOT(slotUpdateVBRCombos()));
     connect(vbr_max_brate,SIGNAL(activated(int)),SLOT(slotConfigChanged()));
 
     connect(vbr_xing_tag,SIGNAL(clicked()),this,SLOT(slotConfigChanged()));
@@ -593,9 +593,22 @@ void KAudiocdModule::slotUpdateVBRWidget
     }
   }
 
-  slotConfigChanged();
+  slotUpdateVBRCombos();
 
   return;
+}
+
+//
+// slot for enabling and disabling VBR bitrate combo's
+//
+
+void KAudiocdModule::slotUpdateVBRCombos() {
+
+  vbr_min_brate->setEnabled((vbr_min_br->isEnabled())&&(vbr_min_br->isChecked())?true:false);
+  vbr_max_brate->setEnabled((vbr_max_br->isEnabled())&&(vbr_max_br->isChecked())?true:false);
+
+  slotConfigChanged();
+
 }
 
 QString KAudiocdModule::quickHelp() const
Index: kcmaudiocd/kcmaudiocd.h
===================================================================
RCS file: /home/kde/kdebase/kioslave/audiocd/kcmaudiocd/kcmaudiocd.h,v
retrieving revision 1.5
diff -u -3 -p -r1.5 kcmaudiocd.h
--- kcmaudiocd/kcmaudiocd.h	2001/07/24 16:28:11	1.5
+++ kcmaudiocd/kcmaudiocd.h	2001/09/02 06:49:50
@@ -50,6 +50,7 @@ private slots:
 
  void slotSelectMethod(int);
  void slotUpdateVBRWidgets();
+ void slotUpdateVBRCombos();
  void slotConfigChanged();
  void slotChangeFilter();
  void slotEcDisable();


[prev in list] [next in list] [prev in thread] [next in thread]