[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH for 2.2 branch: kfind
From:       Waldo Bastian <bastian () kde ! org>
Date:       2001-08-27 21:49:38
[Download RAW message or body]

On Monday 27 August 2001 02:45 pm, Alexander Neundorf wrote:
> I've got the following small patch:
>
> --- kquery.cpp  2001/03/04 17:41:21     1.8
> +++ kquery.cpp  2001/08/27 21:35:10
> @@ -150,7 +150,7 @@
>                 break;
>               }
>
> -            kapp->processEvents();
> +//            kapp->processEvents();
>           }
>
>         if (!found)
>
>
> This call to processEvents() leads to recursion. It is called from inside
> the slot which is connected to newItems(). So this slot is entered again
> from kapp->processEvents() before the file is parsed to the end.
> This patch makes kfind enable/disable the buttons correctly (i.e. the stop
> button is not disabled to early if searching with conationing text).
> Additionally it might fix the various bug reports about kfind eating a lot
> of memory.
>
>
> Can I commit ?
> I'd like to commit the same to kquery.cpp in konqueror/kfindpart.

Given the intrinsical evilness of processEvent() this sounds like a good idea.

Cheers,
Waldo
-- 
KDE 2.2: We deliver.

[prev in list] [next in list] [prev in thread] [next in thread]