[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] final fix for textview probs
From:       MiBrade () gmx ! net
Date:       2001-08-03 12:08:36
[Download RAW message or body]

Hi!

Well, I don't have access to my normal email account, so I have to copy and
pase from
lists.kde.org.

Alex wrote:
> Well, I do object, I couldn't read my mail earlier.
Oh, I'm very sorry :( I got a reply from you at about 7 or 8am and sent you
an explanation immediately without any response, so I thought it's ok.

> My suggestion: if the user starts to select something using the mouse,
check 
> whether he already explicitely selected some files (e.g. using Insert, 
> shift/ctrl+down/up/...). If this is the case and the user uses 
> CTRL+mousebutton to select, keep the former selection and add the new
items.
> If he didn't explicitely select files, but the current file is selected 
> simply because it is the current item, deselect this one first and then
add 
> the new selected items. Therefor we need a new method
> bool KListView::isSomethingExplicitlySelected() 
>    {return !d->selectedBySimpleMove};
Well, the problem is: this is confusing. You'd like to have a selected item
that is used to display the current item (and the current focus of a view).
This is not working anymore
if you started to select something, with my patch you'll still see a
difference. 

> And one more thing:
> 
> in klistview.cpp:
> 
> @@ -518,19 +508,6 @@ void KListView::focusOutEvent( QFocusEve
>    cleanDropVisualizer();
>    cleanItemHighlighter();
> 
> -  d->autoSelect.stop();
> -
> -  if ((d->selectedBySimpleMove)
> -      && (d->selectionMode == Konqueror)
> -      && (fe->reason()!=QFocusEvent::Popup)
>
> are you sure removing d->autoSelect.stop(); is ok ?
No! Sorry, I accidently removed this one (with only three hours of
sleep...). Please can
someone at least fix this? Thanks!

Waldo wrote:
> That would be an invisible state like "this items is being shown as
selected, 
> but it is selected differently as other items but you can't see this 
> difference". I don't think that's a very good idea in general.
Yes, exactly.

> Unfortunately I fail to fully understand the old situation and what
Michael 
> changed about it so I may not be in the best position to judge this.
Well, it was already like this and it led to the problems I described in my
first attempt to fix this. See kde-cvs.

Alex then wrote:
> The point is, if the current item is not selected, you have first to
select 
> it using space if you want to delete it or if you want to open the RMB
menu 
> for this file. This is very inconvinient.
No! Sorry, this is the correct behaviour IMHO. If you want to delete sth.
you have to select it *first*. Using Konqy with the Keyborad only means to move
the thumb only about 1cm anyways, I guess this is acceptable ;-)

> Now if a user selects some files additionally, e.g. using Insert, and then

> moves the cursor around, the current item is no longer automatically 
> selected. IMHO this feels not bad :-)
Yes, it does. Because one time you have the current item shown as a selected
one and the other time as a normal current item. This is not intuitive.

> This helps against the problems I usually have e.g. in midnight commander,

> there I never know if I selected some files and move the "cursor" to
another 
> file and then e.g. delete the files, whether the current file is also
deleted 
> or only the selected ones.
Yup, this was also the aim of my patch ;)

> Now if  I have split konqy into some views and change between the views
and 
> didn't select any files in one view, the selection bar in the former view 
> disappears and appears in the view where I switched to. This makes it
easier 
> to recognize which view is the active one.
Well, please, try my patch. This is still the case.

> He mainly disabled the "the selection bar disappears when I leave a view
and 
> comes back when I enter the view" and he introduced a new current item 
> "style", which might be confused with the selected item "style".
No!! Please, can *anyone* on this list try my patch and give some feedback?
I tried my best to *aviod* confusing the current item with the selected one
and I think I succeeded
quite well. Additionally the patch fixes the use of Konqy's textview with
any other view,
e.g. the Sidebar.

Ok, I don't want to piss Alex, so this is all just my $0.02. But please, try
my patch before complaining :-)

Ciao,
  Michael

PS: Perhaps can have internet access this evening again, otherwise see you
on Wednesday...

-- 
Aufgepasst - jetzt viele 1&1 New WebHosting Pakete ohne
Einrichtungsgebuehr + 1 Monat Grundgebuehrbefreiung!
http://puretec.de/index.html?ac=OM.PU.PU003K00736T0492a

[prev in list] [next in list] [prev in thread] [next in thread]