[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    libkmid important patch
From:       Antonio Larrosa =?iso-8859-1?q?Jim=E9nez?= <larrosa () kde ! org>
Date:       2001-07-31 14:33:23
[Download RAW message or body]

Hi,

The attached patch fixes a silly situation where I sent an allNotesOff 
message to the device before waiting for the song to be terminated.
The patch just moves a line some lines below so it's easy to see it 
doesn't break anything and it's tested to fix libkmid to play the song 
complete until the end.

Please commit and retag this file.

Greetings,

--
Antonio Larrosa Jimenez
KDE Core developer  - larrosa@kde.org
SuSE Labs developer - larrosa@suse.de
http://perso.wanadoo.es/antlarr
KDE - The development framework of the future, today.

["player.cc.diff" (text/x-diff)]

Index: player.cc
===================================================================
RCS file: /home/kde/kdelibs/libkmid/player.cc,v
retrieving revision 1.40
diff -u -p -r1.40 player.cc
--- player.cc	2001/07/29 22:39:31	1.40
+++ player.cc	2001/07/31 14:29:21
@@ -767,7 +767,6 @@ void MidiPlayer::play(bool calloutput,vo
 #ifdef PLAYERDEBUG
   printf("Syncronizing ...\n");
 #endif
-  midi->allNotesOff();
   if (halt) 
     midi->sync(1);
   else 
@@ -775,6 +774,7 @@ void MidiPlayer::play(bool calloutput,vo
 #ifdef PLAYERDEBUG
   printf("Closing device ...\n");
 #endif
+  midi->allNotesOff();
   midi->closeDev();
   ctl->playing=0;
 #ifdef PLAYERDEBUG


[prev in list] [next in list] [prev in thread] [next in thread]