[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] found another listview fix
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-07-31 13:03:03
[Download RAW message or body]

On Tuesday 31 July 2001 13:09, Michael Brade wrote:
> Hi!
> 
> Finally I know the reason for the following bug: start a drag in e.g. Konqy's 
> detailed listview, drop the item somewhere and cancel the action-menu. Now 
> press the Control-button and more the mouse around -> many files will be 
> selected!
Vague rememberance of that indeed :)

> This happens because QListView::contentsMousePressEvent stores true in 
> d->buttonDown but after starting a drag QListView::contentsMouseReleaseEvent 
> (that unsets d->buttonDown again) is never called. Now Qt thinks the button 
> is still pressed in contentMouseMoveEvent after the drag :-(
I see.

> Solution: KListView calles startDrag() somewhen, so I could just put    
> QListView::contentsMouseReleaseEvent( 0 ) in 
> KonqBaseListViewWidget::startDrag() but since the problem could happen 
> elsewhere I'd like to ask you if the attached patch is better and ok for 
> committing. It fixes the problem and can't hurt because it just resets 
> d->buttonDown.

Strange hack, but if it works.... :)

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]