[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] BIG usability improvement for Konqy's listviews
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-07-30 17:34:23
[Download RAW message or body]

On Monday 30 July 2001 16:25, Michael Brade wrote:
> Hi!
> 
> I know it's late but I wasn't able to finish this earlier. The attached patch 
> fixes the annoying behaviour of the listviews not to be able to select more 
> items by just dragging the mouse, this has bugged me since the beginning of 
> KDE 2. Now if you don't click directly on an item and then drag your mouse a 
> rubber is drawn, just like in the iconview. With the control button more 
> selections can be combined.

Woohoo ! You rock !
Excellent work.
I guess you'll even be able to close about 20 "bug reports" ;-)

> I'm not completely finished with the patch since it has a small issue: 
> scrolling down while selecting and then moving the rubber away from the items 
> not all items get deselected, only the visible ones. Not too hard to fix 
> (need to change the way I iterate over the items).
> 
> I definitely want to see this code in KDE 2.2 since it can't really break 
> anyting, the listviews were limited and quite broken long enough. So if 
> nobody objects I'll commit this evening, so that Waldo has a chance to object 
> as well.

I won't object, since you have apparently tested it quite well, and given how many
people asked for this ;)

> For KDE 3.0 I'd like to move this code to KListView but this can be discussed 
> later.
Yes, sounds like a good move.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]