[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Some kpersonalizer bugs (and fixes)
From:       Ralf Nolden <nolden () kde ! org>
Date:       2001-07-30 16:28:22
[Download RAW message or body]

On Monday, 30. July 2001 14:01, Bernhard Rosenkraenzer wrote:
> When all of kde-i18n is installed, and LANG is set to en_US or C,
> kpersonalizer suggests traditional chinese as default language. Looking at
> the code, that's because "zh_*C*N.GBxxxx" happens to be the last language
> in the list that contains "C". ;)
> Fixed by attachment #1.
>
> Also (still at first start, without previous definitions), if LANG is set
> to en_US (which is translated to "C"), the default county becomes the
> invalid selection "Europe, Central" (contains "C"), LANG=de_AT becomes
> Germany ("de") rather than Austria ("at") - the langs variable is read
> from locale/l10n/COUNTRY/entry.desktop (where COUNTRY is the first 2
> letters of $LANG), and de/entry.desktop doesn't say anything about de_AT,
> de_CH or the likes.
> COUNTRY should be the part of the the locale after the "_" (if present),
> truncated at a "." if present.
> Fixed by attachment #2, tested for C, en_US, en_GB, de, de_DE, de_AT,
> zh_CN, zh_CN.GB2312 - does the right thing(tm) for each of them.
>
> ok to commit?
If it works, please. I didn't have any chance to review it yet :( so you may 
ask someone to try it out quickly.

Ralf
>
> LLaP
> bero

-- 
We're not a company, we just produce better code at less costs.
--------------------------------------------------------------------
Ralf Nolden
nolden@kde.org

The K Desktop Environment	The KDevelop Project
http://www.kde.org		http://www.kdevelop.org

[prev in list] [next in list] [prev in thread] [next in thread]