[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: artsd unlimited timeout
From:       Stefan Westerfeld <stefan () space ! twc ! de>
Date:       2001-07-29 13:02:49
[Download RAW message or body]

Hi!

On Sun, Jul 29, 2001 at 02:20:45PM +0200, Dirk Mueller wrote:
> it was changed a few weeks ago, but its still not changed. by default artsd 
> seems to keep the sound connection forever open. before it just timed out 
> after a while. 
> 
> why was that changed. can we have the old behaviour back before release ? (I 
> assume that artsd continues to run and tries to re-open the sound device if 
> it has any work to do)

That it changed is a kcmarts bug, rather than a feature, related to the way
that kcmarts hides the default values in more than one place in the code,...

The attached patch fixes:

 - default for logging level should always be error
 - default for autosuspend should always be 60 seconds
 - autosuspend time box should disable itself if autosuspend is not checked

Please review/test if it fixes the problem.

   Cu... Stefan
-- 
  -* Stefan Westerfeld, stefan@space.twc.de (PGP!), Hamburg/Germany
     KDE Developer, project infos at http://space.twc.de/~stefan/kde *-         

["20010729-kcmarts-defaults.diff" (text/plain)]

Index: arts.cpp
===================================================================
RCS file: /home/kde/kdebase/kcontrol/arts/arts.cpp,v
retrieving revision 1.43
diff -u -r1.43 arts.cpp
--- arts.cpp	2001/06/07 18:26:40	1.43
+++ arts.cpp	2001/07/29 12:57:58
@@ -204,7 +204,7 @@
 	artsConfig->latencySlider->setValue(config->readNumEntry("Latency",250));
 	messageApplication->setText(config->readEntry("MessageApplication","artsmessage"));
 	displayMessage->setChecked(!messageApplication->text().isEmpty());
-	artsConfig->loggingLevel->setCurrentItem(3 - config->readNumEntry("LoggingLevel",0));
+	artsConfig->loggingLevel->setCurrentItem(3 - config->readNumEntry("LoggingLevel",3));
 
 	int rate = config->readNumEntry("SamplingRate",0);
 	if(rate)
@@ -444,6 +444,7 @@
 	artsConfig->soundIO->setEnabled(startServer->isChecked());
 	artsConfig->testSound->setEnabled(startServer->isChecked());
 	autoSuspend->setEnabled(startServer->isChecked());
+	suspendTime->setEnabled(startServer->isChecked() && autoSuspend->isChecked());
 	displayMessage->setEnabled(startServer->isChecked());
 	messageApplication->setEnabled(startServer->isChecked() && displayMessage->isChecked());
 	calculateLatency();
@@ -471,7 +472,7 @@
 	bool startServer = config->readBoolEntry("StartServer",true);
 	bool startRealtime = config->readBoolEntry("StartRealtime",true);
 	bool x11Comm = config->readBoolEntry("X11GlobalComm",false);
-	QString args = config->readEntry("Arguments","-F 10 -S 4096");
+	QString args = config->readEntry("Arguments","-F 10 -S 4096 -s 60 -m artsmessage -l 3");
 
 	delete config;
 


[prev in list] [next in list] [prev in thread] [next in thread]