[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH]: highcolor style
From:       Bradley T Hughes <bhughes () trolltech ! com>
Date:       2001-07-26 10:53:50
[Download RAW message or body]

On Thursday 26 July 2001 12:54, Martijn Klingens wrote:
> On Thursday 26 July 2001 10:53, Wilco Greven wrote:
> > Hi,
> >
> > The following patch should fix #29147. Could someone with who knows
> > the style code better have a look at it?
>
> I don't think this is the way to go. Turning on the background again
> slows down drawing for no reason. Instead the drawing code of the
> toolbar should be fixed IMO. Or KMix should not draw a useless empty
> toolbar there. Please check the following patches instead. One fixes at
> the library level in KToolBar, the other fixes just KMix. Should I
> commit one of those (which one?) or both?

don't commit the patch you just posted until you fix it to delete the 
painters you new.  Why not create them on the stack?

> Martijn

-- 
--
Bradley T. Hughes <bhughes@trolltech.com>
Trolltech AS - Waldemar Thranes gt. 98B N-0175 Oslo, Norway
Office: +47 21604892
Mobile: +47 92019781

[prev in list] [next in list] [prev in thread] [next in thread]