[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Re: patch: khelpcenter close/quit
From:       Thomas Zander <zander () planescape ! com>
Date:       2001-07-25 11:36:37
[Download RAW message or body]


On Wed, Jul 25, 2001 at 01:29:17PM +0200, Martijn Klingens wrote:
> On Wednesday 25 July 2001 12:34, Cornelius Schumacher wrote:
> > > Hmm... then Konqueror should call the "quit" action "close" as well ;-)
> >
> > No, it's the other way around. The patch is fine and Konqueror as well ;-)
> 
> Huh? Indeed the patch is fine, but you don't quit konqi if you select quit, 
> you only close the active window. So that entry should change as well then...
> 
> See attached patch. Ok to commit this? The ctrl-q StdAccel is of course gone, 
> because it IMO doesn't belong there, the ctrl-esc is added for 'close 
> document' (in the 4-key scheme, don't know the default 3-key accel).
> 
> Martijn

I think you need to read up on your SDI standards, one window is one application, 
so quit is correct since it closes that application.
Please don't start a discussion about this!

Your patch is incorrect, the current konqueror behavior is correct.

ps; Martijn; the terminology page of the styleguide should clarify things for 
you.
-- 
Thomas Zander                                            zander@earthling.net
The only thing worse than failure is the fear of trying something new

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]