[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: slavebase.cpp [Correct patch]
From:       Waldo Bastian <bastian () kde ! org>
Date:       2001-07-23 23:08:46
[Download RAW message or body]

On Monday 23 July 2001 03:37 pm, Dawit Alemayehu wrote:
> > But if you look at SlaveBase::mimeType() you will see that that is
> > exactly what happens, the metaData is sent each time the mime-type is
> > send, and after the slave is transferred to another job, both the
> > meta-data and mimetype are send again.
>
> Hmm... how can that be possible ?  I mean the meta-data being re-sent when
> the slave is transferred to another job ? The outgoing meta-data list gets
> cleared not once, but twice in SlaveBase::mimeType().  It gets cleared in
> ::sendMetaData() the first time and then again when the do loop terminates
> in ::mimeType().

Not in my version, it sends the metadata manually with:

      KIO_DATA << mOutgoingMetaData;
      m_pConnection->send( INF_META_DATA, data );

and then only at the end of the function it clears it.

See revision 1.72
date: 2001/03/22 21:21:53;  author: waba;  state: Exp;  lines: +13 -7
* Send the metadata each time we send the mimetype

> > I will try to see if I can reproduce the problem. Do you have a SSL
> > test-site that I can use?
>
> Nope, but just go to any SSL site like https://sourceforge.net and you will
> see.  I put enough debug statements in all these classes to see that the
> meta-data indeed reaches the application correctly which then should result
> in it being cached.  However, it is not there when we actually get around
> to looking for it in KHTMLPart::slotData().  So to me your above
> explanation about the slave being passed over to another job makes sense
> since the patch I reverted fixed the problem. :)

Can you add debug to mimeType to see if it is indeed being sent twice to the 
application, and can you check at the application side if you have indeed a 
different job?

Cheers,
Waldo
-- 
Andrei Sakharov, Exiled 1980-1986, USSR, http://www.aip.org/history/sakharov/
Dmitry Sklyarov, Detained 2001-????, USA, http://www.elcomsoft.com/

[prev in list] [next in list] [prev in thread] [next in thread]