From kde-core-devel Tue Jul 03 05:44:16 2001 From: Waldo Bastian Date: Tue, 03 Jul 2001 05:44:16 +0000 To: kde-core-devel Subject: Re: PATCH: HTTP ioslave port to TCPSlaveBase X-MARC-Message: https://marc.info/?l=kde-core-devel&m=99413929216566 On Monday 02 July 2001 08:55 pm, Dawit Alemayehu wrote: > Hi, > > Here is a link to a first run patch (rather large to post here) that > attempts to port kio_http to use TCPSlaveBase: Haven't tried it yet but it looks good. Do you think you can try to make a "minimal" patch? E.g. you move some functions around and rearrange some indentation at places and that makes it harder than necassery to review the actual changes. Once the functional changes are in place you can always do some cleanup in a seperate patch. Cheers, Waldo -- Insanity is doing the same thing over and over again and expecting a different result.