[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [Fwd: Re: DCOP problem - CVS from overnight]
From:       Christopher Molnar <molnarc () nebsllc ! com>
Date:       2001-06-13 10:37:56
[Download RAW message or body]

Waldo,

The patch works perfectly here. Thank you!

-Chris

Waldo Bastian wrote:
> 
> Please review the attached patch.
> 
> Cheers,
> Waldo
> 
> On Tuesday 12 June 2001 11:37 am, Christopher Molnar wrote:
> > Hello,
> >
> > This message was sent to me.... Goes along with my earlier one in
> > kde-core-devel.
> >
> > Thanks,
> > Chris
> >
> > -------- Original Message --------
> > Subject: Re: DCOP problem - CVS from overnight
> > Date: Tue, 12 Jun 2001 17:57:32 +0100
> > From: Nick Thompson <nickthompson@agere.com>
> > To: Christopher Molnar <molnarc@nebsllc.com>
> >
> > Chris,
> >
> > I'm not on core-devel list, so please can you forward this if it is any
> > use.
> >
> > Klauncher crashes here on Sparc/Solars8 at startup. I believe it is the
> > same problem as you wrote about. Look below in klauncher.cpp:583:
> >
> > look for my comments starting ******. It looks to me like there is a
> > strong possibility of random miss-aligned memory accesses which will
> > cause a data-abort/bus-error. It I have misunderstood, then just ignore
> > me, but those two accesses come right after a string (byte) alignment,
> > so will not be int/long aligned. I don't have a fix for this, looks like
> > one half of a comms link that I have no info about. The change was
> > entered into cvs by 'lunakl', but I have no e-mail address for him/her.
> >
> > Please let me know if this get resolved as KDE is completely hosed for
> > me now :(
> >
> >    char *p = requestData.data();
> >    *(reinterpret_cast<long *>(p)) = request->arg_list.count()+1;
> >    p += sizeof(long);
> >    strcpy(p, request->name.data());
> >    p += strlen(p) + 1;
> >    for(QValueList<QCString>::Iterator it = request->arg_list.begin();
> >        it != request->arg_list.end();
> >        it++)
> >    {
> >       strcpy(p, (*it).data());
> >       p += strlen(p) + 1;
> >    }
> >    *(reinterpret_cast<long *>(p)) = request->envs.count();
> > *****potential unaligned memory access
> >    p += sizeof(long);
> >    for(QValueList<QCString>::ConstIterator it = request->envs.begin();
> >        it != request->envs.end();
> >        it++)
> >    {
> >       strcpy(p, (*it).data());
> >       p += strlen(p) + 1;
> >    }
> >    *(reinterpret_cast<int *>(p)) = 0; // avoid_loops, always false here
> > *****potential unaligned memory access
> >    p += sizeof(int);
> >    if( startup_notify )
> >
> >
> > Nick.
> 
> --
> bastian@kde.org | SuSE Labs KDE Developer | bastian@suse.com
> 
>   ------------------------------------------------------------------------
>                      Name: klauncher.diff
>    klauncher.diff    Type: text/x-c
>                  Encoding: base64

[prev in list] [next in list] [prev in thread] [next in thread]