[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: RFC: TLS default enabled/disabled?
From:       Michael =?iso-8859-1?q?H=E4ckel?= <Michael () Haeckel ! Net>
Date:       2001-05-20 19:15:29
[Download RAW message or body]

On Friday, 18. May 2001 09:15, Aaron J. Seigo wrote:
>
>  1) the kmail developers want it one way
>  2) the kmailsettings/kio_smtp and other kde devels want it another way

Unfurtunately I still can't help much here.

I still simply can't understand why we should have to pay the price of 
changing to a completely different way of storing information about POP and 
IMAP accounts, if we actually want to have SMTP authentification which is 
something completely different.

>  3) development of kmail right now happens mostly through large patches so
> if you sit on large changes for any apreciable amount of time, it becomes a
> nightmare (e.g. its not easy to keep your patch integrated w/others and
> then someone commits some huge patch that they were developing out of cvs
> for the last several weeks and there are conflicts everywhere. bah)

I think large changes require large patches.
Also our opinion is, that the code in CVS should be always ready for general 
use, as long as there is no very good reason against that.

At least I can't remember any big conflicts that would have required more 
than ten minutes of merging in the past time. Also as long only one single 
person works on SMTP, there should no problem appear.

> i will be happy to take up this effort again at a later date when there is
> some common agreement as to how email settings (and perhaps network
> settings in general?) are to be used by KDE applications in their
> interaction with the desktop. until then, there is simply more chaos there
> than makes it worth my time. i have other things to hack on in the
> mean-time. <sarcasm>after all, nobody REALLY needs smtp auth,
> right?</sarcasm>

Your help is really very appreciated, however it is probably in general a bad 
idea to start coding, before the design issues are discussed.

Regards,
Michael Häckel
["from.diff" (text/plain)]

? from.diff
Index: smtp.cc
===================================================================
RCS file: /home/kde/kdebase/kioslave/smtp/smtp.cc,v
retrieving revision 1.57
diff -u -3 -p -r1.57 smtp.cc
--- smtp.cc	2001/05/15 17:47:52	1.57
+++ smtp.cc	2001/05/20 19:12:06
@@ -155,6 +155,7 @@ void SMTPProtocol::put (const KURL &url,
 	QString query = url.query();
 	QString subject = ASCII("missing subject");
 	QString profile = QString::null;
+        QString from = QString::null;
 	QStringList recip, bcc, cc, temp_list;
 
 	GetAddresses(query, ASCII("to="), recip);
@@ -168,6 +169,12 @@ void SMTPProtocol::put (const KURL &url,
 		temp_list.clear();
 	}
 
+	GetAddresses(query, ASCII("from="), temp_list);
+	if (temp_list.count()) {
+		from = temp_list.last();
+		temp_list.clear();
+	}
+
 	GetAddresses(query, ASCII("profile="), temp_list);
 	if (temp_list.count()) {
 		profile = temp_list.last();
@@ -208,11 +215,14 @@ void SMTPProtocol::put (const KURL &url,
 	// if that worked, check to see if we've specified a real name
 	// and then format accordingly (either: emailaddress@host.com or 
 	// Real Name <emailaddress@host.com>)
-	QString from;
-	if (mset->getSetting(KEMailSettings::EmailAddress) != QString::null) {
-		from = mset->getSetting(KEMailSettings::EmailAddress);
-	} else {
-		from = ASCII(DEFAULT_EMAIL);
+	if (from.isEmpty())
+	{
+		if (mset->getSetting(KEMailSettings::EmailAddress) !=
+		  QString::null) {
+			from = mset->getSetting(KEMailSettings::EmailAddress);
+		} else {
+			from = ASCII(DEFAULT_EMAIL);
+		}
 	}
 	from.prepend(ASCII("MAIL FROM: "));
 


[prev in list] [next in list] [prev in thread] [next in thread]