From kde-core-devel  Thu May 10 08:02:48 2001
From: Henrik Johnson <hpj () globecom ! net>
Date: Thu, 10 May 2001 08:02:48 +0000
To: kde-core-devel
Subject: Kicker patch
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=98948411702845
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--------------=_4D480098F6FC08A18928"

--------------=_4D480098F6FC08A18928
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

I've tried to submit this patch again and got no response, so I'm giving=

it a new try.

The patch will add an option to popup the kicker briefly when switching =

desktops if the panel is autohidden. This is usefull to get a brief=20
glimpse at which desktop you are at now.

/Henrik Johnson
GlobeCom AB
--------------=_4D480098F6FC08A18928
Content-Description: filename="kicker-popup.patch"
Content-Disposition: inline; filename="kicker-popup.patch"
Content-Type: text/plain; name ="kicker-popup.patch"
Content-Transfer-Encoding: quoted-printable

? kicker/core/container_button.loT
Index: kicker/core/panel.cpp
=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D=
3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D
=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D=
3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D
=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D=
3D=3D3D=3D3D=3D3D=3D3D
RCS file: /home/kde/kdebase/kicker/core/panel.cpp,v
retrieving revision 1.59
diff -u -5 -r1.59 panel.cpp
--- kicker/core/panel.cpp	2001/04/20 11:12:02	1.59
+++ kicker/core/panel.cpp	2001/04/29 17:41:41
@@ -102,10 +102,11 @@
=3D20
     // instantiate plugin manager and kwin module
     PGlobal::pluginmgr =3D3D new KickerPluginManager();
     PGlobal::kwin_module =3D3D new KWinModule(this );
     connect( PGlobal::kwin_module, SIGNAL( strutChanged() ), this, SLOT=
=3D
( strutChanged() ) );
+    connect( PGlobal::kwin_module, SIGNAL( currentDesktopChanged(int) )=
=3D
, this, SLOT( currentDesktopChanged(int) ) );
=3D20
     // let PGlobal know we are there
     PGlobal::panel =3D3D this;
=3D20
     // panel global tooltip group
@@ -178,10 +179,11 @@
     config->reparseConfiguration();
     emit configurationChanged();
     config->setGroup("General");
=3D20
     _autoHide =3D3D config->readBoolEntry("AutoHidePanel", false);
+    _autoHideSwitch =3D3D config->readBoolEntry("AutoHideSwitch", false=
);=3D

     _hideAnim =3D3D config->readBoolEntry("HideAnimation", true);
     _autoHideAnim =3D3D config->readBoolEntry("AutoHideAnimation", true=
);=3D

     _autoHideDelay =3D3D config->readNumEntry("AutoHideDelay", 3);
     _hideAnimSpeed =3D3D config->readNumEntry("HideAnimationSpeed", 50)=
;
     _autoHideAnimSpeed =3D3D config->readNumEntry("AutoHideAnimationSpe=
ed=3D
", 5);
@@ -259,10 +261,18 @@
     // auto hide - Lotzi B.
     // ... or a user hide - Matthias E.
     if (!_autoHidden && !_userHidden ) {
 	if ( initialGeometry( _pos ) !=3D3D geometry() )
 	    resetLayout();
+    }
+}
+
+void Panel::currentDesktopChanged(int)
+{
+    if (_autoHideSwitch) {
+        autoHide(false);
+        _autohideTimer->start(250, true);
     }
 }
=3D20
 void Panel::resetLayout()
 {
Index: kicker/core/panel.h
=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D=
3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D
=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D=
3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D
=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D=
3D=3D3D=3D3D=3D3D=3D3D
RCS file: /home/kde/kdebase/kicker/core/panel.h,v
retrieving revision 1.18
diff -u -5 -r1.18 panel.h
--- kicker/core/panel.h	2001/04/20 10:17:31	1.18
+++ kicker/core/panel.h	2001/04/29 17:41:41
@@ -110,10 +110,11 @@
     void autoHideTimeout();
     void slotRestart();
     void strutChanged();
     void showScrollButtons(bool);
     void containerSizeHintChanged();
+    void currentDesktopChanged(int);
=3D20
 private:
=3D20
     void animatedHide(bool left);
=3D20
@@ -122,10 +123,11 @@
     bool _showLeftHB;
     bool _showRightHB;
     int _HBwidth;
     int _panelsize;
     bool _autoHide;
+    bool _autoHideSwitch;
     bool _autoHidden;
     bool _userHidden;
     bool _hideAnim, _autoHideAnim;
     int _autoHideDelay;
     int _hideAnimSpeed, _autoHideAnimSpeed;
Index: kcontrol/kicker/generaltab.ui
=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D=
3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D
=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D=
3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D
=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D=
3D=3D3D=3D3D=3D3D=3D3D
RCS file: /home/kde/kdebase/kcontrol/kicker/generaltab.ui,v
retrieving revision 1.6
diff -u -5 -r1.6 generaltab.ui
--- kcontrol/kicker/generaltab.ui	2001/04/20 11:14:16	1.6
+++ kcontrol/kicker/generaltab.ui	2001/04/29 17:41:44
@@ -378,10 +378,21 @@
                     <property stdset=3D3D"1">
                         <name>text</name>
                         <string>Enable automatic hide</string>
                     </property>
                 </widget>
+               <widget>
+                    <class>QCheckBox</class>
+                    <property stdset=3D3D"1">
+                        <name>name</name>
+                        <cstring>m_autoHideSwitch</cstring>
+                    </property>
+                    <property stdset=3D3D"1">
+                        <name>text</name>
+                        <string>Show panel when switching desktop</stri=
=3D
ng>
+                    </property>
+                </widget>
                 <widget>
                     <class>QLayoutWidget</class>
                     <property stdset=3D3D"1">
                         <name>name</name>
                         <cstring>Layout30</cstring>
@@ -531,10 +542,16 @@
 </widget>
 <connections>
     <connection>
         <sender>m_autoHide</sender>
         <signal>toggled(bool)</signal>
+        <receiver>m_autoHideSwitch</receiver>
+        <slot>setEnabled(bool)</slot>
+    </connection>
+    <connection>
+        <sender>m_autoHide</sender>
+        <signal>toggled(bool)</signal>
         <receiver>m_delaySlider</receiver>
         <slot>setEnabled(bool)</slot>
     </connection>
     <connection>
         <sender>m_autoHide</sender>
@@ -570,10 +587,11 @@
 <tabstops>
     <tabstop>m_bottomButton</tabstop>
     <tabstop>m_normal</tabstop>
     <tabstop>m_large</tabstop>
     <tabstop>m_autoHide</tabstop>
+    <tabstop>m_autoHideSwitch</tabstop>
     <tabstop>m_delaySlider</tabstop>
     <tabstop>m_delaySpinBox</tabstop>
     <tabstop>m_terminalInput</tabstop>
 </tabstops>
 </UI>
Index: kcontrol/kicker/generaltab_impl.cpp
=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D=
3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D
=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D=
3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D
=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D=
3D=3D3D=3D3D=3D3D=3D3D
RCS file: /home/kde/kdebase/kcontrol/kicker/generaltab_impl.cpp,v
retrieving revision 1.10
diff -u -5 -r1.10 generaltab_impl.cpp
--- kcontrol/kicker/generaltab_impl.cpp	2001/04/21 13:24:07	1.10
+++ kcontrol/kicker/generaltab_impl.cpp	2001/04/29 17:41:44
@@ -38,10 +38,11 @@
 {
     // connections
     connect(m_locationGroup, SIGNAL(clicked(int)), SIGNAL(changed()));
     connect(m_sizeGroup, SIGNAL(clicked(int)), SIGNAL(changed()));
     connect(m_autoHide, SIGNAL(clicked()), SIGNAL(changed()));
+    connect(m_autoHideSwitch, SIGNAL(clicked()), SIGNAL(changed()));
     connect(m_delaySlider, SIGNAL(valueChanged(int)), SIGNAL(changed())=
=3D
);
     connect(m_delaySpinBox, SIGNAL(valueChanged(int)), SIGNAL(changed()=
=3D
));
     connect(m_terminalInput, SIGNAL(textChanged(const QString&)), SIGNA=
=3D
L(changed()));
     connect(m_percentSlider, SIGNAL(valueChanged(int)), SIGNAL(changed(=
=3D
)));
     connect(m_percentSpinBox, SIGNAL(valueChanged(int)), SIGNAL(changed=
=3D
()));
@@ -61,10 +62,14 @@
                                      "after some time and reappear when=
=3D
 you move the mouse to the "
                                      "screen edge the panel is attached=
=3D
 to. "
                                      "This is particularly useful for s=
=3D
mall screen resolutions, "
                                      "for example, on laptops.") );
=3D20
+    QWhatsThis::add(m_autoHideSwitch, i18n("If this option is enabled, =
=3D
the panel will automatically show "
+					   "itself for a brief period of time when the desktop is switched=
=3D
 "
+					   "so you can see what desktop you are on.") );
+
     QString delaystr =3D3D i18n("Here you can change the delay after wh=
ic=3D
h the panel will disappear"
                             " if not used.");
=3D20
     QWhatsThis::add(m_delaySlider, delaystr);
     QWhatsThis::add(m_delaySpinBox, delaystr);
@@ -85,13 +90,15 @@
=3D20
     m_sizeGroup->setButton(c->readNumEntry("Size", 2));
     m_locationGroup->setButton(c->readNumEntry("Position", 3));
=3D20
     bool ah =3D3D c->readBoolEntry("AutoHidePanel", false);
+    bool ahs =3D3D c->readBoolEntry("AutoHideSwitch", false);
     int delay =3D3D c->readNumEntry("AutoHideDelay", 3);
=3D20
     m_autoHide->setChecked(ah);
+    m_autoHideSwitch->setChecked(ahs);
     m_delaySlider->setValue(delay);
     m_delaySpinBox->setValue(delay);
     m_delaySlider->setEnabled(ah);
     m_delaySpinBox->setEnabled(ah);
=3D20
@@ -120,10 +127,11 @@
     c->setGroup("General");
=3D20
     c->writeEntry("Size", m_sizeGroup->id(m_sizeGroup->selected()));
     c->writeEntry("Position", m_locationGroup->id(m_locationGroup->sele=
=3D
cted()));
     c->writeEntry("AutoHidePanel", m_autoHide->isChecked());
+    c->writeEntry("AutoHideSwitch", m_autoHideSwitch->isChecked());
     c->writeEntry("AutoHideDelay", m_delaySlider->value());
     c->writeEntry( "SizePercentage", m_percentSlider->value() );
     c->writeEntry( "ExpandSize", m_expandCheckBox->isChecked() );
=3D20
     c->setGroup("misc");
--------------=_4D480098F6FC08A18928--