From kde-core-devel  Sun Mar 25 18:38:39 2001
From: Charles Samuels <charles () kde ! org>
Date: Sun, 25 Mar 2001 18:38:39 +0000
To: kde-core-devel
Subject: Re: KAboutData(const KAboutData &)
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=98554570532313

On Sunday 25 March 2001 09:58 am, Simon Hausmann wrote:
> On Sun, Mar 25, 2001 at 09:46:19AM -0800, Charles Samuels wrote:
> > Are there any arguments against me giving KAboutData a copy construct=
or?
>
> Then you should make all related classes completely value based
> (KAboutPerson, etc.) and also add an assignment operator, IMHO.
I disagree, this is relatively simple class, and absolute maximum speed i=
s=20
required, since the hit is startup, and that's where KDE has the most spe=
ed=20
problems.

>
> > Each Noatun plugin will have a function capable of returning KAboutDa=
ta,
> > where the framework will create the KAboutDialog from that.
>
> Usually there exists only one KAboutData object per instance, so what a=
bout
> retrieving a pointer to the plugin's KAboutData instead? (like it is do=
ne
> for kparts components for example)
>
> (of course making clear that the ownership remains with the plugin)
And the code would be significantly easier to write and maintain.  I don'=
t=20
see how returning a pointer to the plugin's KAboutData is any different t=
han=20
using the copy constructor, other than making the code simpler.

-Charles

--=20
Charles Samuels <charles@kde.org>
K Desktop Environment
"The people. Could you patent the sun?"
 -- Jonas E. Salk, when asked who owned the patent on his polio vaccine.