[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: QPushButton problem with KDE styles
From:       mosfet <mosfet () mandrakesoft ! com>
Date:       2001-03-20 23:11:30
[Download RAW message or body]

Oh, I see now ;-) We were getting 2 pixels sunken in instead of one.
Thanks!

As far as coding style, somethings I can't tell myself what's up because
I use ? : too liberally... I'm a lazy typer :P

So your doing these updates? If you keep the effect stuff in that's cool
and appreciated :)

Martijn Klingens wrote:
> 
..snip...
> And the remark: I don't know who wrote the original Highcolor version, but
> there was a bug in the code. The code  'x1 + act ? 1 : 0' is evaluated as
> '(x1 + act) ? 1 : 0' and not as the (in this case expected and required) 'x1
> + (act ? 1 : 0)'. I hope this actually was a typo and in the original code
> the end result was the same, so nobody noticed until now. Nevertheless, I
> think it doesn't hurt to mention this (potential) pitfall with the C++
> operator precedence order here.
> 
> I'm not advocating my own coding style here as I tend to use too much
> brackets (just to make sure and too lazy to test if they're really needed),
> but too less as in this case isn't good either. Also, please don't take this
> as a flame, but learn from this experience as much as I (hopefully) do from
> my own mistakes.
> 
> Regards,
> 
> Martijn

[prev in list] [next in list] [prev in thread] [next in thread]