[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Fwd: PATCH fix for Bug 20393 Would someone please review?
From:       Cullmann Christoph <crossfire () babylon2k ! de>
Date:       2001-02-14 18:30:24
[Download RAW message or body]

----------  Weitergeleitete Nachricht  ----------
Subject: PATCH fix for Bug 20393 Would someone please review?
Date: Wed, 14 Feb 2001 12:21:49 -0600
From: Scott Manson <Maniac@Alltel.net>
To: kde-devel@max.tat.physik.uni-tuebingen.de


Hello
After some investigation into 20393 I think I found the problem
it seems that KWriteDoc->removeView was never called and
therefore there was still a view in the KTextDocument::View list
that had already been deleted. The fix was to uncomment
line this line
kWriteDoc->removeView( this );
in kwview.cpp around line 1560 +/- a few lines )
It looks like this has been here since late May



--
Maniac@alltel.net 40° 37' 9" N, 96° 57' 24" W
A single tasking guy in multi tasking world

-------------------------------------------------------

["kwview.diff" (text/x-c++)]

Index: kwview.cpp
===================================================================
RCS file: /home/kde/kdebase/kwrite/kwview.cpp,v
retrieving revision 1.154
diff -u -r1.154 kwview.cpp
--- kwview.cpp	2001/02/06 02:24:47	1.154
+++ kwview.cpp	2001/02/14 18:14:26
@@ -1557,7 +1557,7 @@
   }
   delete kspell.ksc;
 
-  //  kWriteDoc->removeView( this );
+  kWriteDoc->removeView( this );
 
   if ( kWriteDoc->isLastView(0) && !kWriteDoc->isSingleViewMode() )
     delete kWriteDoc;


[prev in list] [next in list] [prev in thread] [next in thread]