[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: KAction::setText(int, const QString&)
From:       John Birch <jbb () kdevelop ! org>
Date:       2001-02-17 23:11:38
[Download RAW message or body]

On Sun, 18 Feb 2001 03:30, Christian Gebauer wrote:
> Simon Hausmann wrote:
> > On Sat, Feb 17, 2001 at 11:38:09AM +0100, Peter Putzer wrote:
> > > The attached patch fixes a small bug in Konsole (and possibly other
> > > apps):
> > >
> > > when you renamed a session in Konsole, the associated entry in the
> > > toolbar was only updated after a paint event got triggered (for example
> > > by moving the cursor over the button).
> >
> > Just a thought: Shouldn't the KToolBarButton class take care of that and
> > now the caller?
>
> Indeed, I think this is the correct fix, please review.
>
> diff -u -3 -p -r1.43 ktoolbarbutton.cpp
> --- ktoolbarbutton.cpp  2000/12/16 19:08:13     1.43
> +++ ktoolbarbutton.cpp  2001/02/17 14:28:46
> @@ -212,8 +212,11 @@ void KToolBarButton::modeChange()
>      mysize = QSize(pix_width, pix_height);
>      setMinimumSize( mysize );
>      updateGeometry();
> +    QToolButton::setUsesTextLabel(false);
>      return;
>    }
> +
> +  QToolButton::setUsesTextLabel(true);

Hmm - This causes really large buttons for all toolbars if you have text 
aside icon and small icons. The button height always becomes the size to fit 
text under icons, which is very ugly in konsole's toolbar. Perhaps the 
kaction patch would be a better solution?

jbb

[prev in list] [next in list] [prev in thread] [next in thread]