[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: filetypes module (#10302)
From:       Dawit Alemayehu <adawit () kde ! org>
Date:       2001-02-02 20:58:10
[Download RAW message or body]

On Friday 02 February 2001 13:59, Carsten Pfeiffer wrote:
> Hi,
>
> this patch fixes the "kcmshell filetypes" crashing when removing the only
> visible item. It allows you to add new filetypes while a filter is
> active and it doesn't throw all added filetypes anymore away (or re-add
> removed items), when changing the filter. Basically, this filtering was
> pretty broken.
>
> Please test/review.
>
> Cheers,
> Carsten Pfeiffer

Looks good.  Another thing that needs to be fixed with the control panel is that
once a person pressed an "Apply", there should be a flag to see if any more
changes were performed and if not we should not do yet another save.  Right now
pressing Apply followed by Ok results in saving twice...

Regards,
Dawit A.

[prev in list] [next in list] [prev in thread] [next in thread]