[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    PATCH: #17183, Taskbar does not comply with Fitts' Law
From:       Daniel Naber <daniel.naber () t-online ! de>
Date:       2001-01-31 19:09:10
[Download RAW message or body]

Hi,

this fixes #17183 for both horizontal and vertical alignment. Can I commit?

Regards
 Daniel

-- 
Daniel Naber, Paul-Gerhardt-Str. 2, 33332 Guetersloh, Germany
Tel. 05241-59371, Mobil 0170-4819674

["fitts-law-on-taskbar.diff" (text/x-c++)]

Index: taskbarapplet.cpp
===================================================================
RCS file: /home/kde/kdebase/kicker/applets/taskbar/taskbarapplet.cpp,v
retrieving revision 1.20
diff -u -r1.20 taskbarapplet.cpp
--- taskbarapplet.cpp	2001/01/29 22:25:24	1.20
+++ taskbarapplet.cpp	2001/01/31 19:12:10
@@ -494,7 +494,7 @@
     m_pScroller->setVScrollBarMode(QScrollView::AlwaysOff);
     m_pScroller->setHScrollBarMode(QScrollView::AlwaysOff);
     m_pScroller->setFrameStyle(QFrame::StyledPanel | QFrame::Sunken);
-    m_pScroller->setLineWidth(1);
+    m_pScroller->setLineWidth(0);	// set to 0 to obey Fitt's Law
     m_pScroller->resize(0,0); //   initialize with nulls
 
     m_pTaskbarArea = new TaskBar(m_pScroller->viewport());
@@ -563,8 +563,8 @@
             nHg = scroll_area_max_size;
         }
 
-        m_pScroller->resizeContents(width()-2, nHg);
-        m_pTaskbarArea->resize(width()-2, nHg);
+        m_pScroller->resizeContents(width(), nHg);
+        m_pTaskbarArea->resize(width(), nHg);
         m_nButtonsAreaSize = m_pTaskbarArea->height();
 
         if (m_nButtonsAreaSize <= scroll_area_max_size)
@@ -585,8 +585,8 @@
             nWd = scroll_area_max_size;
         }
 
-        m_pScroller->resizeContents(nWd, height()-2);
-        m_pTaskbarArea->resize(nWd-2, height()-2);
+        m_pScroller->resizeContents(nWd, height());
+        m_pTaskbarArea->resize(nWd-2, height());
         m_nButtonsAreaSize = nWd;//m_pTaskbarArea->width();
 
         if (m_nButtonsAreaSize <= scroll_area_max_size)


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic