[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Patch for krdb - concerning "strange" color schemes
From:       Stephan Kulow <coolo () kde ! org>
Date:       2001-01-31 13:27:56
[Download RAW message or body]

Hans Meine wrote:
> 
> Stephan Kulow <coolo@kde.org> writes:
> > Hmm, I don't understand. WINDOW_FOREGROUND is the color for normal widgets like
> > menus and scrollbars. Using .text() sounds wrong.
> Hmm, seems to me FOREGROUND is for normal widgets, WINDOW_FOREGROUND should be
> for text widgets, no?
> 
> > BTW: Either kcmcolors or the default style is wrong in using the color for the popupmenus.
> > While kcmcolor shows the foreground() kedit shows the button foreground for it.
> Right. That's a discrepancy.
> 
> * Text fields and similar (should be text() on base()):
>   - works for konsole "System colors" scheme, kedits text field and other
>     KDE/Qt (multi)line edits
>   - kwrite uses own configurable colors..no "System colors" option yet :-(
>     (probably because of difficulties with highlighting on strange backgrounds)
>   - *xterm uses foreground() on base() before my patch*, this is especially
>     ugly in my scheme, where I got black on really dark brown, then. :-(
>   - *xemacs* the same
Hmm, I ruined my colours setup and xemacs looked the same as kedit to me, but
perhaps I didn't ruin it enough.

> 
> * Dialog colors (foreground() on background()):
>   - KDE dialogs, scrollbars, sliders, labels use foreground() on background()
>   - xclock, xlogo, xmag and so on, too. Fine.
> 
> * text() on background():
>   - KDE toolbar captions
>   - Combo boxes (normal display, use text()/base() for popup)
>   - KDE menus are using a mixture of buttonText() and text() on background()

That's definitly in bug in the styles then. Can you look in that too?

> 
> And here's another patch which makes applying new colors calling "kcminit style"
> the right way, again (works fine here at least):
> 
 
The patch is wrong. KConfig reads kdeglobals too and krdb _is_ kcminit style

Greetings, Stephan

-- 
It's my true belief that people having wishes for the bug report tool
and report it to the author haven't got the idea behind open source.
                                             anonymous KDE developer

[prev in list] [next in list] [prev in thread] [next in thread]