[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Patch for krdb - concerning "strange" color schemes
From:       Hans Meine <hans_meine () gmx ! net>
Date:       2001-01-31 11:03:08
[Download RAW message or body]

Hi everybody,

I was testing color schemes again, lately. KDE in general does work
now quite fine with "reversed" schemes where "bgcolor darker fgcolor".
To make it short(er), I put a (sorry, large ;-) ) screenshot on

   http://www.chiefrocker.net/kde-seire.png

I propose the following patch which made this scheme work for legacy
apps. The problem was, that there are two fgcolor/bgcolor combinations
which were mixed up here if I understood that correctly.
The previous code would make emacs run the menu text color (foreground())
on my "text widget background" (base()). In fact, IMO it should have been
the corresponding text widget foreground text() instead:

Index: krdb.cpp
===================================================================
RCS file: /home/kde/kdebase/kcontrol/display/krdb.cpp,v
retrieving revision 1.4
diff -b -u -3 -p -d -r1.4 krdb.cpp
--- krdb.cpp    2001/01/17 22:05:33     1.4
+++ krdb.cpp    2001/01/31 10:50:37
@@ -182,7 +182,7 @@ void runRdb() {
   addColorDef(preproc, "SELECT_BACKGROUND"  , cg.highlight());
   addColorDef(preproc, "SELECT_FOREGROUND"  , cg.highlightedText());
   addColorDef(preproc, "WINDOW_BACKGROUND"  , cg.base());
-  addColorDef(preproc, "WINDOW_FOREGROUND"  , cg.foreground());
+  addColorDef(preproc, "WINDOW_FOREGROUND"  , cg.text());
   addColorDef(preproc, "INACTIVE_BACKGROUND", KGlobalSettings::inactiveTitleColor());
   addColorDef(preproc, "INACTIVE_FOREGROUND", KGlobalSettings::inactiveTitleColor());
   addColorDef(preproc, "ACTIVE_BACKGROUND"  , KGlobalSettings::activeTitleColor());

-- 
Ciao,  /  /
      /--/
     /  / ANS                          .,* Hamburg, Germany *,.

[prev in list] [next in list] [prev in thread] [next in thread]