[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KDialog & kcmshell
From:       Stephan Kulow <coolo () kde ! org>
Date:       2001-01-16 12:25:54
[Download RAW message or body]

Espen Sand wrote:
> 
> On Tue, 16 Jan 2001, Stephan Kulow wrote:
> > Matthias Elter wrote:
> > >
> > > On Tuesday 16 January 2001 10:06, Espen Sand wrote:
> > > > Please, no different sized buttons as the default mode. In most cases
> > > > uni size buttons looks better. Anyway:
> > > (...)
> > >
> > > Buttons using their preferred size is a UI design standard. I don't think we
> > > should break it for dialogs just because it looks better in some cases.
> > I think so too. I changed the default to false and nothing I looked at looks
> > worse. The standard buttons have a size that fits for No, Yes and Cancel just
> > perfectly without the need to resize OK to "Use defaults". You can't even say
> > for which dialog MultiSize is ok and for which it's not because of translations.
> > I would remove this whole UniSize completly.
> 
> ok, multisize by default should be fine then. Note that
> mButton.resize( true, 0, spacingHint(), mButtonOrientation ) is used
> more than one place in KDialogBase
> 
OK, I commited s/true/false on all mButton.resize calls til you implement the hook.

Gretings, Stephan

-- 
It's my true belief that people having wishes for the bug report tool
and report it to the author haven't got the idea behind open source.
                                             anonymous KDE developer

[prev in list] [next in list] [prev in thread] [next in thread]