[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KDialog & kcmshell
From:       Stephan Kulow <coolo () kde ! org>
Date:       2001-01-16 11:45:48
[Download RAW message or body]

Waldo Bastian wrote:
> 
> On Monday 15 January 2001 13:35, Stephan Kulow wrote:
> > rik@kde.org wrote:
> > > #if Stephan Kulow
> > >
> > > > Hi!
> > > >
> > > > kcmshell uses KDialogBase and if you look at a kcmshell
> > > > (right click on kicker's clock and choose date format for
> > > > example) you'll see that all buttons have the size of
> > > > "Use Defaults". This sucks in Germany at last where the
> > > > i18n() is "Voreinstellungen benutzen".
> > > > But I can't find the code where the buttons are layed out.
> > > > The default kcontrol doesn't space these buttons, so should
> > > > kcmshell. If just I could find the guilty code. Can someone
> > > > help?
> > >
> > > Looks like KDialogBase::setButtonStyle()
> >
> > Yes, it calls SButton.resize(sameSize=true, ...
> > There is no code calling resize(false within kdialogbase and this
> > whole class is private to KDialogBase and there is no way to
> > change this sameSize behaviour. I hardcoded false and it unbroke
> > kcmshell.
> > I wonder who would want all buttons to have the same size, so
> > I would change it to call =false before 2.1 if noone speaks up
> 
> Well.. if you have e.g. "Yes" / "No" or "Yes"/"No"/"Cancel" it looks much
> better if they have the same size. The problems start if there is one button
> that is much bigger than the rest.
> 
But there is no way to disable this behaviour. Maybe we should fix KDialogBase
to detect that one button is >20% larger or something?

Greetings, Stephan

-- 
It's my true belief that people having wishes for the bug report tool
and report it to the author haven't got the idea behind open source.
                                             anonymous KDE developer

[prev in list] [next in list] [prev in thread] [next in thread]