On Wednesday 27 December 2000 20:58, Matthias Kiefer wrote:
> Hi,
>=20
> I would like to add the attached patches for KAboutData and for=20
> KAboutApplication. It brings the ability to show the translator(s) of t=
he=20
> application in the aboutDialog. I think this will give some motivation =
to the=20
> translators ;-)
> You can see, how the about dialogs looks like in the attached screensho=
t. The=20
> message about the translation teams is intended to get replaced about=20
> information about the translation team of the current language.
>=20
> Please review and say if it is ok to commit.=20
>=20
>=20
> To enable showing the translators, one have to call=20
> KAboutData::setTranslator(const char *names, const char *emails) with s=
ome=20
> dummy text marked for translation, e.g.=20
> aboutData.setTranslator(I18N_NOOP("NAMES OF THE=20
> TRANSLATORS"),I18N_NOOP("EMAIL OF THE TRANSLATORS"));
>=20
> Then the translators can replace this text with a comma separated list =
of=20
> names and email addresses. If there is no translation or the default la=
nguage=20
> is used, then the texts are ignored and no translator page is shown in =
the=20
> about dialog.

This looks great to me. Please commit.

> I have added an additional class KAboutTranslator , because KAboutPerso=
n uses=20
> internaly const char *, so there would be a memory leak when using it o=
r one=20
> would have to keep a reference to the string in the object. Maybe someo=
ne has=20
> a idea how to solve this?

Hmm, I don't see the point in not using KAboutPerson.
The char * is allocated for the duration of the program anyway
since it's set to a litteral string ("blah").
I suggest to use KAboutPerson for translators too - yes, they are
persons too :-)

> Additionaly I changed KAboutPerson to use QString::fromUtf8() instead o=
f=20
> QString::fromLatin1(), so it is now possible to use non-latin1 characte=
rs in=20
> names of developers and others.
Definitely correct.

> Please also have a look at  binary compatibility, because I had to add =
two=20
> private members to KAboutData and therefore had to create the private d=
=20
> pointer.
Looks ok.

--=20
David FAURE, david@mandrakesoft.com, faure@kde.org
http://www.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today