From kde-core-devel Mon Dec 25 15:03:03 2000 From: Thiago Macieira Date: Mon, 25 Dec 2000 15:03:03 +0000 To: kde-core-devel Subject: Re: PATCH: Re: Bug#17623: VFS: file-max limit 4096 reached (because of X-MARC-Message: https://marc.info/?l=kde-core-devel&m=97775660923204 Michael Häckel wrote: > in TCPSlaveBase::ConnectToHost, is this code correct ? Should > there be no close(m_iSock) before the return statements ? Fix > see below, untested yet. Please edit the line ::connect first, might > be wrapped. [snip] > /tmp# diff -u old /u2/src/cvs/kde/kdelibs/kio/tcpslavebase.cpp [snip] Yes, there open sockets have to be closed somewhere. It seems they are not being closed. My suggestion is that, if the connection failed, you close it. There's no need to keep it open further on. So, the patch is correct. The only problem is the patch affects code I will remove due to the IPv6 implementation. So, even though it's needed (dubbed grave bug), it'll only be temporary. Note: I am still having problems posting to this list. The mail server doesn't like my @mail.com e-mail. -- Thiago Macieira - UFOT Registry number: 1001 thiagom@mail.com talha@geocities.com ICQ UIN: 1967141 PGP: 0x8F2978D5 and 0xEA9037A5 Registered Linux user #65028 171/378. Yes, ma'am. Its ion signature leads directly to that...whatever it is. -- Ens. Tom Paris, "Dark Frontier, Part II"