[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: make kdeinit exit when it's not needed anymore
From:       Simon Hausmann <sh () caldera ! de>
Date:       2000-11-30 15:05:19
[Download RAW message or body]

On Wed, Nov 29, 2000 at 10:57:18PM +0000, David Faure wrote:
> The attached patches make kdeinit exit 10 seconds after the last
> KDE application (DCOP-enabled) exits.
> 
> This fixes problems that people are having when using KDE applications
> out of KDE (3 or 4 processes are left running after they close the last
> KDE application).
> 
> In short, dcopserver has a reference counter of registered applications,
> which excludes the daemons (klauncher, kded and knotify).
> 
> In more details (i.e. for Waldo :), when dcopserver's refcount is 0,
> a timer is started, and if it's still the case after 10 seconds
> [this is to prevent KDE from exiting on startup :)], then it emits a DCOP
> signal "terminateKDE()". I had to add support for dcop signals _sent_
> by the DCOPServer.
> KLauncher is connected to this signal, and upon receiving it,
> it sends a command to kdeinit to tell it to exit. I have tested, and this
> effectively kills the daemons as well, as expected.

This is great! Thanks David :)
 
> This is a bit central to KDE, so a bit of peer review can't hurt :-)

As far as I understand the patch it looks excellent.
One small thing I noticed was that the daemons are hardcoded :)
Perhaps we should introduce some kind of I-am-a-daemon flag?
(like extending the "register" call to the dcopserver with a
bool bDaemon or something like that?)

Bye,
 Simon

[prev in list] [next in list] [prev in thread] [next in thread]