[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Bug in KMainWindow::toolBar()
From:       mosfet <mosfet () mandrakesoft ! com>
Date:       2000-11-28 2:38:54
[Download RAW message or body]

David Faure wrote:
> 
> On Monday 27 November 2000 23:33, mosfet wrote:
> > David Faure wrote:
> > >
> > > On Monday 27 November 2000 06:51, mosfet wrote:
> > > > David Faure wrote:
> > > > >
> > > > > On Saturday 25 November 2000 02:19, mosfet wrote:
> > > > > > Everything seems to be ported to XML by now in kdebase and utils... I
> > > > > > just tried apps and looked for ones with missing toolbars :P I ran into
> > > > > > the bug because the thumbnail viewer for Pixie isn't converted to XML
> > > > > > yet.
> > > > >
> > > > > kdelibs/kdeui/tests/kwindowtest.cpp is a plain KMainWindow, no XML,
> > > > > and the toolbars show up fine.
> > > >
> > > > It creates it's own toolbar with new. Remember, I said that works ;-)
> > >
> > > Grr .. please provide an example code (e.g. a diff for kwindowtest)
> > > that shows the bug. I'm not going to dig around until I see a bug, when
> > > everything I've tried up to now works just fine.
> >
> > Grr... you didn't try everything, so what your saying is everything you
> > use is okay but not everything in the API works :P
> 
> I'm just saying, show me the bug ! Why do you expect me to try every
> combination of possible API call until I find it ?!?!?
> 
> > If you don't want to fix the bug fine
> I never said that !
> 
> > - I already changed my code to work around it.
> Certainly the best approach to the problem, heh ?
> 
> > If you want to see it in kwindowtest simply change the lines that call new
> > KToolBar to toolBar()!
> > You'll also have to change the variable name that
> > it uses for the pointer because it uses the name "toolBar", which
> > obviously conflicts with the method. Stupid stuff.
> Yup. Note how much it would be easier if you would just send a patch
> instead of letting me do what you apparently already did.
> 
> Well, WTH. Did that, tested it, works fine. So where on earth do you
> see a bug ?
> I committed the new program, so that you can verify by yourself.
> 

The requirement for calling addToolBar is new - KTMainWindow didn't
require this for toolbars created with the toolBar() call, nor did
KMainWindow until a few days ago. That is where I ran into the problem.
Either this needs to change to act like the old behavior or please add a
note in the doc for toolBar. The old behavior was that the toolBar would
automatically show up. Now it only does if you call addToolBar.

> > > > What doesn't is having the mainwindow create it's own automatically by
> > > > calling toolBar();
> > > Remind me your nationality ? :-)
> > WTF does nationality have to do with anything?
> Re-read your initial sentence and tell me if that was understandable English !
> 

Yes, it was... "It creates it's own toolbar with new. Remember, I said
that works ;-) What doesn't is having the mainwindow create it's own
automatically by calling toolBar();"

What is not understandable to you here?

> --
> David FAURE, david@mandrakesoft.com, faure@kde.org
> http://www.mandrakesoft.com/~david/, http://www.konqueror.org/
> KDE, Making The Future of Computing Available Today
> See http://www.kde.org/kde1-and-kde2.html for how to set up KDE 2

[prev in list] [next in list] [prev in thread] [next in thread]