[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCHES] fix tmpnam() issue for kdelibs
From:       Kevin Lo <kevlo () kde ! org>
Date:       2000-11-23 9:01:43
[Download RAW message or body]

David Faure wrote:

> On Wednesday 22 November 2000 09:31, Stephan Kulow wrote:
> > Kevin Lo wrote:
> > >
> > > Hi,
> > >
> > > The  following patches is to fix tmpnam() issue for
> > > kdesu/kdesu_stub.c and libkmid/midfile.cc in kdelibs.
> > > I will commit it if no problem, thanks.
> > >
> > Hmm, can't we centralice this a bit more? I don't like
> > the #ifdefs everywhere.
>
> Other bits of KDE simply use KTempFile, save the name, and delete
> the KTempFile object. It's not 100% safe for race conditions but it's already
> better than tmpnam. The 100% safe solution is to actually _use_ KTempFile.

I looked at the code, seems to take the time to fix some methods type from
char * to QString if I use KTempFile. I'll fix them in HEAD, but can we put my
patches in KDE_2_0_BRANCH?
Stephan said he didn't like the #ifdefs everywhere, neither did I.
Please take a look at kdelibs/dcop/dcopserver.cpp and
kdebase/ksmserver/server.cpp, looks like #ifdefs everywhere as well.
Anyway, please consider my patches into KDE_2_0_BRANCH first, then
I'll use KTempFile in HEAD, agree?

P.S. Using my patches will let BSDer happier...

> --
> David FAURE
> david@mandrakesoft.com, faure@kde.org
> http://home.clara.net/faure/, http://www.konqueror.org/
> KDE, Making The Future of Computing Available Today

- Kevin

[prev in list] [next in list] [prev in thread] [next in thread]