[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: QIconView crash workaround
From:       David Faure <david () mandrakesoft ! com>
Date:       2000-10-14 16:40:58
[Download RAW message or body]

On Saturday 14 October 2000 15:39, Carsten Pfeiffer wrote :
>On Sat, Oct 14, 2000 at 04:20:37PM +0000, David Faure wrote:
>
>Hi,
> 
>> Sounds good, but why can't I reproduce the crash with konqueror, even
>> in an empty directory (I would guess that in this case there is no current item :-)  ?
>> It's using Extended too....
>> 
>> Just wondering, don't bother if you don't want to :-)
>
>yes, it only happens when clicking on an item, so there has to be an item
>at all. You may check qiconview.cpp, contentsMousePressEvent(), there are
>a few if-clauses. In the first clause, there is if ( d->currentItem &&
>....), but later it simply does else if ( d->currentItem->x() ... ) ;(
>
>If you didn't update kfile already, make kfstest && ./kfstest and
>shift-click on an item. If you did update, revert to the previous
>kfileview.cpp, which didn't contain the workaround.

Oh, I trust you that this fixes a bug in kfile. What I'm trying to see is if
konqueror has the same bug, but it seems there is always a current item
in a konqueror icon view.....

Anyway, feel free to fix kiconview.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://www.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today
See http://www.kde.org/kde1-and-kde2.html for how to set up KDE 2

[prev in list] [next in list] [prev in thread] [next in thread]