[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kicker patch
From:       Torsten Rahn <torsten () kde ! org>
Date:       2000-10-13 4:55:03
[Download RAW message or body]

Antonio Larrosa wrote:
> 
> Hello,
> 
> This patch makes kicker not to show any icon instead of showing the
> unknown icon with the question mark when there's no icon for an app.
> I think it looks _much_ better this way.

As long as this is *only* the case for the kicker-menu go ahead!
I remember that it looked much better, too.

Tackat

> Any objections to commit ?
> 
> Greetings,
> 
> --
> Antonio Larrosa Jimenez
> KDE core developer
> antlarr@arrakis.es        larrosa@kde.org
> http://www.arrakis.es/~rlarrosa
> KDE - The development framework of the future, today.
> 
>   ------------------------------------------------------------------------
> Index: service_mnu.cpp
> ===================================================================
> RCS file: /home/kde/kdebase/kicker/ui/service_mnu.cpp,v
> retrieving revision 1.4
> diff -u -r1.4 service_mnu.cpp
> --- service_mnu.cpp     2000/10/09 21:30:11     1.4
> +++ service_mnu.cpp     2000/10/12 19:21:52
> @@ -95,6 +95,7 @@
> 
>      int id = idStart;
> 
> +    KIconLoader *loader = KGlobal::instance()->iconLoader();
>      for (; it != list.end(); ++it) {
> 
>         KSycocaEntry * e = *it;
> @@ -140,7 +141,8 @@
>             // to accelators, replace them with two ampersands.
>             serviceName.replace(QRegExp("&"), "&&");
> 
> -           int newId = insertItem(SmallIconSet(s->icon()), serviceName, id++);
> +           int newId = insertItem( loader->loadIcon(s->icon(), KIcon::Small,
> +                 0, KIcon::DefaultState, 0L, true), serviceName, id++);
>             entryMap_.insert(newId, static_cast<KSharedPtr<KSycocaEntry> >(s));
>         }
>      }

[prev in list] [next in list] [prev in thread] [next in thread]