[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Showstopper in Kit
From:       Charles Samuels <charles () altair ! dhs ! org>
Date:       2000-10-11 7:08:39
[Download RAW message or body]

(This email forwardded from Neil Stevens who doesn't have write to 
kde-core-devel, in addition, I have to, ironically, not use my @kde.org 
address for the same reason, hint hint ;)


Do programmers make bad testers?  You be the judge.

I always save my password, and coincidentally, Kit is broken for users who
don't save their passwords.  This patch makes it work.  No messages
changed, hardly anything touched.

User after user is complaining... the flood will only grow if this doesn't
go into the final release.

--
Neil Stevens
multivac@fcmail.com
neil@qualityassistant.com

keyserver search.keyserver.net
Fingerprint 86EA ECD4 F258 FB1B D88F 9136 4F49 90F8 CD3E 5C1C

-------------------------------------------------------



["savepasswordfix.diff" (text/x-java)]

Index: twindow.cpp
===================================================================
RCS file: /home/kde/kdenetwork/kit/twindow.cpp,v
retrieving revision 1.27
diff -u -r1.27 twindow.cpp
--- twindow.cpp	2000/09/30 14:03:05	1.27
+++ twindow.cpp	2000/10/11 06:59:34
@@ -210,11 +210,11 @@
 			{
 				// if no password or username specified, ask for one
 				// if the dialog returns successfully, try again
-				if( (profile->data()->name.isNull() || profile->data()->password.isNull()) )
-				{
+				if( profile->data()->name.isNull() ||
+				    (!profile->data()->password.length() && !profile->data()->savePassword)
+				  )
 					profile->execEditor();
-					return;
-				}
+				aim.setPassword(profile->data()->password);
 				aim.setStatus(TAIM_ONLINE);
 				initTree();
 			}


[prev in list] [next in list] [prev in thread] [next in thread]